Send "Accept" request header to indicate RFC 9457 compliance#1846
Merged
Send "Accept" request header to indicate RFC 9457 compliance#1846
Conversation
Also evaluate RFC 9457 responses for PUT requests Add tests to check for proper "Accept" headers for GET/HEAD/PUT This closes #1845
cstamas
reviewed
Apr 20, 2026
|
|
||
| protected boolean hasRFC9457ContentType(String contentType) { | ||
| return "application/problem+json".equals(contentType); | ||
| return CONTENT_TYPE_PROBLEM_DETAILS_JSON.equals(contentType); |
Member
There was a problem hiding this comment.
CF sends Content-Type: application/problem+json; charset=utf-8 on response, so equality will not work.
Member
There was a problem hiding this comment.
Maybe just "contains" or "starts with"? (with proper nullcheck on contentType?). Just to keep it simple.
Member
Author
There was a problem hiding this comment.
I strip attributes from that header now in e4521fa.
Add IT against Cloudflare provided RFC 9457 endpoints (https://blog.cloudflare.com/rfc-9457-agent-error-pages/#how-to-use-it)
cstamas
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also evaluate RFC 9457 responses for PUT requests
Add tests to check for proper "Accept" headers for GET/HEAD/PUT
This closes #1845
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.