fix deprecation notices for suiteXmlFiles parameter

- `@deprecated` annotation should be placed after docs ...
- drop some of the unused methods

Author: slawekjaranowski

maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java

@@ -308,14 +308,14 @@ public class IntegrationTestMojo extends AbstractSurefireMojo {
     private int rerunFailingTestsCount;
 
     /**
-     * @deprecated not supported after 3.6.0, please use groups or Junit suite support
      * (TestNG) List of <suiteXmlFile> elements specifying TestNG suite xml file locations. Note that
      * {@code suiteXmlFiles} is incompatible with several other parameters of this plugin, like
      * {@code includes} and {@code excludes}.<br>
      * This parameter is ignored if the {@code test} parameter is specified (allowing you to run a single test
      * instead of an entire suite).
      *
      * @since 2.2
+     * @deprecated not supported after 3.6.0, please use groups or Junit suite support
      */
     @Parameter(property = "failsafe.suiteXmlFiles")
     @Deprecated

maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/BooterDeserializerProviderConfigurationTest.java

@@ -279,8 +279,4 @@ private StartupConfiguration getTestStartupConfiguration(ClassLoaderConfiguratio
     private File getTestSourceDirectory() {
         return new File("TestSrc");
     }
-
-    private List<String> getSuiteXmlFileStrings() {
-        return Arrays.asList("A1", "A2");
-    }
 }

maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/BooterDeserializerStartupConfigurationTest.java

@@ -206,8 +206,4 @@ private StartupConfiguration getTestStartupConfiguration(ClassLoaderConfiguratio
     private File getTestSourceDirectory() {
         return new File("TestSrc");
     }
-
-    private String[] getSuiteXmlFileStrings() {
-        return new String[] {"A1", "A2"};
-    }
 }

maven-surefire-plugin/src/main/java/org/apache/maven/plugin/surefire/SurefireMojo.java

@@ -287,14 +287,14 @@ public class SurefireMojo extends AbstractSurefireMojo implements SurefireReport
     private int failOnFlakeCount;
 
     /**
-     * @deprecated not supported after 3.6.0, please use groups or Junit suite support
      * (TestNG) List of <suiteXmlFile> elements specifying TestNG suite xml file locations. Note that
      * {@code suiteXmlFiles} is incompatible with several other parameters of this plugin, like
      * {@code includes} and {@code excludes}.<br>
      * This parameter is ignored if the {@code test} parameter is specified (allowing you to run a single test
      * instead of an entire suite).
      *
      * @since 2.2
+     * @deprecated not supported after 3.6.0, please use groups or Junit suite support
      */
     @Deprecated
     @Parameter(property = "surefire.suiteXmlFiles")