Remove redundant ITs and resource cleanups (#3319)

When we have one provider test with empty, the same profiles are redundant

remove unused ITs resources

Author: slawekjaranowski

surefire-its/src/test/java/org/apache/maven/surefire/its/CheckTestFailIfNoTestsIT.java

@@ -49,13 +49,4 @@ public void dontFailIfNoTests() {
         TestFile reportsDir = outputValidator.getSurefireReportsFile("");
         assertFalse(reportsDir.exists(), "Unexpected reports directory");
     }
-
-    @Test
-    public void jUnit48CategoriesFailWhenNoTests() {
-        unpack().failIfNoTests(false)
-                .activateProfile("junit47")
-                .setJUnitVersion("4.12")
-                .executeTest()
-                .verifyErrorFreeLog();
-    }
 }

surefire-its/src/test/java/org/apache/maven/surefire/its/TestMultipleMethodsIT.java

@@ -46,9 +46,4 @@ public OutputValidator multipleMethod(String projectName, String... goals) {
     public void testJunit44() {
         multipleMethod("junit44-multiple-methods");
     }
-
-    @Test
-    public void testJunit5() {
-        multipleMethod("junit44-multiple-methods");
-    }
 }

surefire-its/src/test/java/org/apache/maven/surefire/its/TestSingleMethodIT.java

@@ -51,20 +51,9 @@ public OutputValidator singleMethod(
         return launcher.executeTest().verifyErrorFreeLog().assertTestSuiteResults(1, 0, 0, 0);
     }
 
-    @Test
-    public void testJunit44() {
-        singleMethod("junit44-single-method", Collections.emptyMap(), null);
-    }
-
-    @Test
-    public void testJunit48Provider4() {
-        singleMethod("junit48-single-method", Collections.emptyMap(), null, "-P surefire-junit4");
-    }
-
     @Test
     public void testJunit48Provider47() {
-        singleMethod("junit48-single-method", Collections.emptyMap(), null, "-P surefire-junit47")
-                .verifyTextInLog(RUNNING_WITH_PROVIDER47);
+        singleMethod("junit48-single-method", Collections.emptyMap(), null).verifyTextInLog(RUNNING_WITH_PROVIDER47);
     }
 
     @Test
@@ -91,20 +80,7 @@ public void testTestNg5149() {
 
     @Test
     public void fullyQualifiedJunit48Provider4() {
-        singleMethod(
-                "junit48-single-method",
-                Collections.emptyMap(),
-                "junit4.BasicTest#testSuccessOne",
-                "-P surefire-junit4");
-    }
-
-    @Test
-    public void fullyQualifiedJunit48Provider47() {
-        singleMethod(
-                "junit48-single-method",
-                Collections.emptyMap(),
-                "junit4.BasicTest#testSuccessOne",
-                "-P surefire-junit47");
+        singleMethod("junit48-single-method", Collections.emptyMap(), "junit4.BasicTest#testSuccessOne");
     }
 
     @Test

surefire-its/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1209RerunAndForkCountIT.java

@@ -35,37 +35,20 @@ public class Surefire1209RerunAndForkCountIT extends SurefireJUnit4IntegrationTe
     private static final String SUMMARY_COUNTS = "Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Flakes: 2";
 
     @Test
-    public void reusableForksJUnit47() throws VerificationException {
+    public void reusableForksJUnit() throws VerificationException {
         unpack().executeTest()
                 .assertTestSuiteResults(5, 0, 0, 0, 4)
                 .assertThatLogLine(containsString(SUMMARY_COUNTS), is(1));
     }
 
     @Test
-    public void notReusableForksJUnit47() throws VerificationException {
+    public void notReusableForksJUnit() throws VerificationException {
         unpack().reuseForks(false)
                 .executeTest()
                 .assertTestSuiteResults(5, 0, 0, 0, 4)
                 .assertThatLogLine(containsString(SUMMARY_COUNTS), is(1));
     }
 
-    @Test
-    public void reusableForksJUnit4() throws VerificationException {
-        unpack().activateProfile("junit4")
-                .executeTest()
-                .assertTestSuiteResults(5, 0, 0, 0, 4)
-                .assertThatLogLine(containsString(SUMMARY_COUNTS), is(1));
-    }
-
-    @Test
-    public void notReusableForksJUnit4() throws VerificationException {
-        unpack().activateProfile("junit4")
-                .reuseForks(false)
-                .executeTest()
-                .assertTestSuiteResults(5, 0, 0, 0, 4)
-                .assertThatLogLine(containsString(SUMMARY_COUNTS), is(1));
-    }
-
     private SurefireLauncher unpack() {
         return unpack("surefire-1209-rerun-and-forkcount");
     }