Issue #2613 Debugging failsafe tests: Message 'Listening for transport dt_socket at address' is not displayed anymore when using maven.surefire.debug (#3353) (#3354)

Signed-off-by: Olivier Lamy <olamy@apache.org>

Author: olamy

surefire-api/src/main/java/org/apache/maven/surefire/api/stream/AbstractStreamDecoder.java

@@ -112,9 +112,28 @@ protected void debugStream(byte[] array, int position, int remaining) {}
 
     protected MT readMessageType(@Nonnull Memento memento) throws IOException, MalformedFrameException {
         byte[] header = getEncodedMagicNumber();
-        int readCount = DELIMITER_LENGTH + header.length + DELIMITER_LENGTH + BYTE_LENGTH + DELIMITER_LENGTH;
-        read(memento, readCount);
-        checkHeader(memento);
+        // Read the header one byte at a time so that non-protocol output (e.g. the JDWP
+        // "Listening for transport dt_socket at address: ..." line) is flushed to the console
+        // before the decoder blocks. That line contains ':' which looks like a frame start;
+        // checking each magic-number byte individually lets us bail out immediately on a
+        // mismatch instead of stalling on a 24-byte read that never completes.
+        read(memento, DELIMITER_LENGTH);
+        ByteBuffer bb = memento.getByteBuffer();
+        if ((bb.array()[bb.arrayOffset() + bb.position()] & 0xff) != ':') {
+            checkHeader(memento); // not ':', immediately throws MalformedFrameException
+        }
+        checkDelimiter(memento); // consume the ':'
+        for (int i = 0; i < header.length; i++) {
+            read(memento, DELIMITER_LENGTH);
+            bb = memento.getByteBuffer();
+            if ((bb.array()[bb.arrayOffset() + bb.position()] & 0xff) != (header[i] & 0xff)) {
+                // Mismatch: report the ':' plus all bytes read so far in this frame attempt.
+                throw new MalformedFrameException(memento.getLine().getPositionByteBuffer(), bb.position() + 1);
+            }
+            bb.position(bb.position() + 1);
+        }
+        read(memento, DELIMITER_LENGTH);
+        checkDelimiter(memento);
         return messageTypes.get(readSegment(memento));
     }