Fix typos and improve clarity in index.apt.vm#371
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes typos and improves clarity in the Maven Wrapper documentation file. The changes focus on correcting grammatical errors and enhancing readability in the APT format documentation.
- Capitalized "Maven" for consistency and proper noun usage
- Added missing articles ("the") for better grammatical structure
- Improved punctuation and sentence flow
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| but every distribution has specific content to manage different strategies to get {{{../maven-wrapper/}<<<maven-wrapper.jar>>>}}: | ||
|
|
||
| - <<<only-script>>>: the new lite implementation of <<<mvnw>>>/<<<mvnw.cmd>>> scripts will download the maven directly with <<<wget>>> or <<<curl>>> on *nix, or PowerShell on Windows, then exec/call the original <<<mvn>>>/<<<mvn.cmd>>> scripts of the downloaded maven distribution, skipping <<<maven-wrapper.jar>>>. | ||
| - <<<only-script>>>: the new lite implementation of <<<mvnw>>>/<<<mvnw.cmd>>> scripts will download Maven directly with <<<wget>>> or <<<curl>>> on *nix, or PowerShell on Windows, then exec/call the original <<<mvn>>>/<<<mvn.cmd>>> scripts of the downloaded maven distribution, skipping <<<maven-wrapper.jar>>>. |
There was a problem hiding this comment.
The word 'maven' at the end of the line should be capitalized to 'Maven' for consistency with the rest of the documentation where Maven is treated as a proper noun.
Suggested change
| - <<<only-script>>>: the new lite implementation of <<<mvnw>>>/<<<mvnw.cmd>>> scripts will download Maven directly with <<<wget>>> or <<<curl>>> on *nix, or PowerShell on Windows, then exec/call the original <<<mvn>>>/<<<mvn.cmd>>> scripts of the downloaded maven distribution, skipping <<<maven-wrapper.jar>>>. | |
| - <<<only-script>>>: the new lite implementation of <<<mvnw>>>/<<<mvnw.cmd>>> scripts will download Maven directly with <<<wget>>> or <<<curl>>> on *nix, or PowerShell on Windows, then exec/call the original <<<mvn>>>/<<<mvn.cmd>>> scripts of the downloaded Maven distribution, skipping <<<maven-wrapper.jar>>>. |
| ---- | ||
|
|
||
| - <<<source>>>: on *nix, if <<<wget>>> and <<<curl>>> are not available, <<<mvnw>>> script will compile <<<MavenWrapperDownloader.java>>> source then run the class to download {{{../maven-wrapper/}<<<maven-wrapper.jar>>>}}: | ||
| - <<<source>>>: on *nix, if <<<wget>>> and <<<curl>>> are not available, the <<<mvnw>>> script will compile <<<MavenWrapperDownloader.java>>>, then run the class to download {{{../maven-wrapper/}<<<maven-wrapper.jar>>>}}: |
There was a problem hiding this comment.
The phrase 'on *nix' should be capitalized to 'On *nix' since it begins a sentence.
Suggested change
| - <<<source>>>: on *nix, if <<<wget>>> and <<<curl>>> are not available, the <<<mvnw>>> script will compile <<<MavenWrapperDownloader.java>>>, then run the class to download {{{../maven-wrapper/}<<<maven-wrapper.jar>>>}}: | |
| - <<<source>>>: On *nix, if <<<wget>>> and <<<curl>>> are not available, the <<<mvnw>>> script will compile <<<MavenWrapperDownloader.java>>>, then run the class to download {{{../maven-wrapper/}<<<maven-wrapper.jar>>>}}: |
cstamas
approved these changes
Sep 17, 2025
|
@elharo Please assign appropriate label to PR according to the type of change. |
elharo
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.