Fix wrong distribution URL output in only-script on some Unix systems#373
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes incorrect verbose logging in the Maven Wrapper's only-script mode on Unix systems. The issue occurs when the unzip command is not available, causing the script to fall back to downloading a .tar.gz file instead of the originally specified .zip file, but the verbose logs still show the original .zip URL.
- Moves verbose logging statements to occur after the distribution URL fallback logic
- Ensures accurate logging when debugging with
MVNW_VERBOSE=true
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
slachiewicz
approved these changes
Oct 2, 2025
tyreektyreek7
approved these changes
Oct 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tl;dr: moves output of distribution URL in
only-scriptmode on Unix to after its final determinationExecuting mvnw with the following config (correct
distributionSha256Sumfor the specified .zip file) on a Linux system without theunzipcommand not only fails because the .tar.gz file is downloaded as a fallback (see #285 for that) but also produces wrong logs when debugging withMVNW_VERBOSE=true:The logs (using a Fedora container as an example of a distro without
unzip) look like this:Nothing in this log indicates that the .tar.gz file was downloaded instead of the .zip file. Line 3 and 4 even wrongly state the exact oposite. This does not help in realizing a fallback file was actually fetched for which the (otherwise possibly correct)
distributionSha256Sumdoes not match.This happens because the verbose messages are output immediately before the availability of
unzipis determined and a fallback distribution URL and download path are possibly set. Switching the order of output and check would greatly improve comprehensibility when trying to figure out what actually went wrong in the already convoluted scenario outlined above.Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.