Fix script sha256sum verification on macOS#393
Merged
Conversation
Without it, the macOS implementation exits with code 0 for malformed input, triggering a false positive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a vulnerability/bug in the mvnw script on macOS where malformed SHA-256 checksums in the distributionSha256Sum property may pass validation despite being invalid. This only impacts cases where the checksum is incorrectly formatted, not when it's correctly formatted but incorrect.
This occurs because the script invokes sha256sum without the
--strictflag, and macOS's Darwin implementation does not enforce strict format checking by default, unlike GNU coreutils. When a malformed checksum is provided (e.g., an extra hex character), sha256sum emits a warning to stderr but returns a success exit code, which the script interprets as valid. Since stderr is redirected to /dev/null, the warning is silenced. The issue affects both mvnw and only-mvnw scripts. The fix adds the--strictflag to ensure improperly formatted checksum lines cause validation to fail, aligning macOS behavior with Linux.Unfortunately I did not find an easy way to make a test for this.
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.