Conversation
Things have been improved a lot in Maven 4... |
gnodet
left a comment
gnodet
left a comment
There was a problem hiding this comment.
Review: Add test for prefixed Maven elements
Good regression test — XML namespace prefixes (e.g., <mvn:project> instead of <project>) are a valid but rarely used XML feature that could easily break in POM parsers. This covers a genuine edge case.
The test follows the established pattern in DefaultMavenTest exactly: getProject(name) → create execution request with validate goal → execute → check result. The companion prefix/pom.xml correctly uses the mvn: prefix on all elements.
The drive-by fix of "Error" → "Errors" in testThatErrorsDuringProjectDependencyGraphCreationAreStored is a welcome typo correction.
LGTM — no issues found.
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Claude Code on behalf of Guillaume Nodet
Reviewed 3 PRs: apache#2333 (server aliases, clean), apache#10971 (test, LGTM), apache#11186 (namespace validation, needs rework). 18 reviews total. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Can someone press the approve button? |
2 participants
I was pleasantly surprised that this test passed.