Filter project repos with uninterpolated property expressions#12204
Open
gnodet wants to merge 2 commits into
Open
Filter project repos with uninterpolated property expressions#12204gnodet wants to merge 2 commits into
gnodet wants to merge 2 commits into
Conversation
Projects like uima-uimaj, opennlp-sandbox, and seatunnel-shade define
repositories with ${eclipseP2RepoId} in the repo ID. This property is
never defined — it was used as a literal string in Maven 3. Maven 4
rejects it with IllegalArgumentException at runtime.
Extend the mvnup compatibility fix strategy to detect and comment out
repositories and plugin repositories whose id or url contain undefined
property expressions, following the same pattern used for dependencies
(apache#12080). Handles both root-level and profile-level repositories.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gnodet
added a commit
that referenced
this pull request
Jun 1, 2026
#12204) Cherry-pick from fix/filter-unresolvable-project-repos branch. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gnodet
added a commit
that referenced
this pull request
Jun 1, 2026
#12204) Cherry-pick from fix/filter-unresolvable-project-repos branch. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When a project POM defines repositories with ${...} expressions that
cannot be resolved (e.g. ${eclipseP2RepoId}), Maven 4 previously
failed with InternalErrorException. This change downgrades the model
validation from ERROR to WARNING and filters such repositories before
they reach the resolver, logging a warning instead of failing the build.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gnodet
changed the title
gnodet
added a commit
that referenced
this pull request
Jun 2, 2026
…(PR #12204) Cherry-pick from fix/filter-unresolvable-project-repos branch. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rmannibucau
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mvnup apply(commit 1)${...}expressions in repository IDs/URLs from ERROR to WARNING, and filter such repositories inDefaultProjectBuildingHelper.createArtifactRepositories()before they reach the resolver (commit 2)DefaultArtifactDescriptorReader.filterUninterpolated()for transitive dependency repos (PR Transitive dependency POMs with uninterpolated repository IDs cause build failures #12086), but for project-defined repositoriesFixes runtime failures like
InternalErrorException: Not fully interpolated remote repository ${eclipseP2RepoId}seen in projects such asuima-uimaj,opennlp-sandbox, andseatunnel-shadewhose POMs define repositories with property expressions that are never defined.Test plan
DefaultModelValidatorTest— uninterpolated expression checks now expect warnings instead of errorsMavenITgh11140RepoInterpolationTestandMavenITgh11140RepoDmUnresolvedTest— builds succeed with warnings instead of failinguima-uimaj: aftermvnup apply,mvn validatesucceeds with warningSkipping repository '${eclipseP2RepoId}' ...instead of the previous fatal errorimpl/maven-impl,impl/maven-core,compat/maven-model-builder)🤖 Generated with Claude Code