Skip to content

[INFRA] Set up default rulesets for default and release branches #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asf-gitbox-commits wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[INFRA] Set up default rulesets for default and release branches #898

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions .asf.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,26 @@ github:
- apache
features:
issues: true
dependabot_alerts: true
dependabot_alerts: true
dependabot_updates: true
ghp_branch: gh-pages
ghp_path: /

rulesets:
- name: "Default Branch Protection"
type: branch
branches:
includes:
- "~DEFAULT_BRANCH"
- "release/*"
- "rel/*"

@tomaswolf tomaswolf May 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have "release/*" or "rel/*" branches. If we did branches for releases (which will come once we publish 3.0.0), I think I'd rather name them "rel_*". Currently we just tag releases.

But in any case that can be done once we do have release branches. At this point adding these two patterns is YAGNI.

excludes: []
bypass_teams:
- root

@tomaswolf tomaswolf May 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who is this team "root"? Is there a team for PMC members? I'd like to have at least someone in the Apache MINA PMC to have the rights to bypass these restrictions.

restrict_deletion: true

@tomaswolf tomaswolf May 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone creates a "rel" or "release" branch by mistake, how can I then remove that?

restrict_force_push: true

@tomaswolf tomaswolf May 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just restricts force pushes, right? Direct fast-forward pushes are still possible?

notifications:
commits: commits@mina.apache.org
issues: dev@mina.apache.org
commits: commits@mina.apache.org
issues: dev@mina.apache.org
pullrequests: dev@mina.apache.org
jira_options: link
Loading