fix portability: replace min() macro with MIN()#2243
Merged
Conversation
sjanc
requested changes
May 29, 2026
sjanc
left a comment
sjanc
left a comment
Contributor
There was a problem hiding this comment.
Hi,
ble_ll_utils.h already provides MIN() macro which should be used instead
manuelinbrain
force-pushed
the
fix-min-macro-portability
branch
from
a99dfa3 to
7651395
Compare
Replace min() macro usage with MIN() for portability reasons.
manuelinbrain
force-pushed
the
fix-min-macro-portability
branch
from
7651395 to
744529b
Compare
Contributor
Author
|
Hi, It's already done. Thanks |
manuelinbrain
changed the title
sjanc
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some standalone builds (non-Mynewt environments) do not provide min() macro by default, which can lead to compilation failures in controller sources depending on the toolchain.
This change replace min() macro with MIN() to improve portability.