nimble/audio: Bound broadcast sink subgroup count#2251
Open
Old-Ding wants to merge 2 commits into
Open
Conversation
Old-Ding
force-pushed
the
fix/broadcast-sink-subgroups-bound
branch
from
e23bad0 to
577a451
Compare
Old-Ding
changed the title
Contributor
|
Hi, I have mixed feelings on this PR, while fix itself seems to be OK from quick look, unittest is not building, and if it would build it would fail (due to #2254). So, was this tested at all? |
Reject sync requests whose subgroup count exceeds the broadcast sink subgroup array before copying BIS sync values into it. The previous code relied on a debug assertion in the scan delegator path, but production builds can still receive an oversized sync option. Fixes apache#2188 Signed-off-by: Old-Ding <ai.neo.ae86@gmail.com>
Old-Ding
force-pushed
the
fix/broadcast-sink-subgroups-bound
branch
from
577a451 to
a1471dd
Compare
The audio unit test now builds the broadcast sink, whose GAP handler uses PAST and BIGInfo report fields and calls ble_gap_periodic_adv_sync_receive(). Enable those periodic advertising features in the test syscfg so the corresponding host declarations are visible. Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
ble_audio_broadcast_sink_config()copiedsync_opt->num_subgroupsinto
sink->num_subgroupsand then used it as the loop bound for thefixed
sink->subgroups[]array. The visible guard was only a debugassertion in the scan delegator path, so production builds could still
receive an oversized sync option.
Enabling
BLE_AUDIO_BROADCAST_SINKin the audio unit test also compilesble_audio_broadcast_sink.c, whose GAP handler references periodic synctransfer and BIGINFO report event fields. The test syscfg now enables the
feature flags that expose those fields and declarations.
Validation
git diff --checknewt test @apache-mynewt-nimble/nimble/host/audio/test -j 4parses the package and updated syscfg on this Windows host, then stops at the native compiler step becausegccis unavailable locally.pull_requestworkflows for heade93fbb98e6eec1e69680067a7dcba30f28fb9e31areaction_requiredwith no jobs, so the PR is waiting for maintainer workflow approval before those CI jobs can rerun.Fixes #2188.