Skip to content

Commit 0d27eac

Browse files
authored
MINIFICPP-2857 Processors w/o relationships have incomplete manifest … (#2207)
1 parent 4ca62e0 commit 0d27eac

2 files changed

Lines changed: 10 additions & 3 deletions

File tree

.github/references/ubuntu_22_04_clang_arm_manifest.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4418,6 +4418,9 @@
44184418
"defaultValue": "false"
44194419
}
44204420
},
4421+
"inputRequirement": "INPUT_ALLOWED",
4422+
"isSingleThreaded": "false",
4423+
"supportedRelationships": [],
44214424
"typeDescription": "This processor can throw exceptions in onTrigger and onSchedule calls based on configuration. Only for testing purposes.",
44224425
"supportsDynamicRelationships": "false",
44234426
"supportsDynamicProperties": "false",
@@ -6033,6 +6036,9 @@
60336036
"type": "org.apache.nifi.minifi.processors.LogAttribute"
60346037
},
60356038
{
6039+
"inputRequirement": "INPUT_ALLOWED",
6040+
"isSingleThreaded": "false",
6041+
"supportedRelationships": [],
60366042
"typeDescription": "This processor logs a message on destruction. Only for testing purposes.",
60376043
"supportsDynamicRelationships": "false",
60386044
"supportsDynamicProperties": "false",

libminifi/src/core/state/nodes/AgentInformation.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,9 @@ std::string allowedTypeArtifactName(const std::string_view allowed_type, const s
7575
return "minifi-system";
7676
}
7777

78-
void serializeClassDescription(const std::vector<ClassDescription>& descriptions, const std::string& name, SerializedResponseNode& response) {
78+
void serializeClassDescription(const std::vector<ClassDescription>& descriptions,
79+
const std::string& name,
80+
SerializedResponseNode& response) {
7981
if (descriptions.empty()) {
8082
return;
8183
}
@@ -142,8 +144,7 @@ void serializeClassDescription(const std::vector<ClassDescription>& descriptions
142144
desc.children.push_back(props);
143145
}
144146

145-
// only for processors
146-
if (!class_description.class_relationships_.empty()) {
147+
if (class_description.type_ == ResourceType::Processor) {
147148
desc.children.push_back({.name = "inputRequirement", .value = class_description.inputRequirement_});
148149
desc.children.push_back({.name = "isSingleThreaded", .value = class_description.isSingleThreaded_});
149150

0 commit comments

Comments
 (0)