Skip to content

Commit 4429809

Browse files
committed
kafka rebase fixes
1 parent 7af861e commit 4429809

3 files changed

Lines changed: 8 additions & 2 deletions

File tree

extension-framework/cpp-extension-lib/mocklib/src/mock-minifi-c.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,4 +134,9 @@ MinifiStatus MinifiControllerServiceContextGetProperty(MinifiControllerServiceCo
134134
void (*)(void* user_ctx, MinifiStringView property_value), void*) {
135135
throw std::runtime_error("Not implemented");
136136
}
137+
138+
MinifiStatus MinifiProcessContextGetProxyDataFromProperty(MinifiProcessContext*, MinifiStringView,
139+
void (*)(void* user_ctx, const MinifiProxyData* proxy_data), void*) {
140+
throw std::runtime_error("Not implemented");
141+
}
137142
} // extern "C"

extensions/kafka/KafkaProcessorBase.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,15 +25,15 @@ KafkaProcessorBase::KafkaProcessorBase(core::ProcessorMetadata metadata) : Proce
2525
}
2626

2727
std::optional<api::utils::net::SslData> KafkaProcessorBase::getSslData(api::core::ProcessContext& context) const {
28-
return context.getSslData(SSLContextService) | utils::toOptional();
28+
return context.getSslData(SSLContextService).value_or(std::nullopt);
2929
}
3030

3131
void KafkaProcessorBase::setKafkaAuthenticationParameters(api::core::ProcessContext& context, gsl::not_null<rd_kafka_conf_t*> config) { // NOLINT(performance-unnecessary-value-param)
3232
security_protocol_ = api::utils::parseEnumProperty<kafka::SecurityProtocolOption>(context, SecurityProtocol);
3333
utils::setKafkaConfigurationField(*config, "security.protocol", std::string{magic_enum::enum_name(security_protocol_)});
3434
logger_->log_debug("Kafka security.protocol [{}]", magic_enum::enum_name(security_protocol_));
3535
if (security_protocol_ == kafka::SecurityProtocolOption::ssl || security_protocol_ == kafka::SecurityProtocolOption::sasl_ssl) {
36-
if (auto ssl_data = context.getSslData(SSLContextService) | utils::toOptional()) {
36+
if (auto ssl_data = getSslData(context)) {
3737
if (ssl_data->ca_loc.empty() && ssl_data->cert_loc.empty() && ssl_data->key_loc.empty() && ssl_data->key_pw.empty()) {
3838
logger_->log_warn("Security protocol is set to {}, but no valid security parameters are set in the properties or in the SSL Context Service.",
3939
magic_enum::enum_name(security_protocol_));

extensions/kafka/rdkafka_utils.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
#include "rdkafka.h"
2626
#include "api/utils/Ssl.h"
2727
#include "minifi-cpp/core/logging/Logger.h"
28+
#include "magic_enum/magic_enum.hpp"
2829

2930
namespace org::apache::nifi::minifi::utils {
3031

0 commit comments

Comments
 (0)