Apply suggestions from code review

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Author: martinzink

extension-framework/cpp-extension-lib/mocklib/include/MockLogger.h

@@ -27,7 +27,7 @@ class MockLogger : public core::logging::Logger {
  public:
   void set_max_log_size(int) override {}
   void log_string(const core::logging::LOG_LEVEL level, std::string s) override { logs_[level].emplace_back(std::move(s)); }
-  [[nodiscard]] bool should_log(const core::logging::LOG_LEVEL level) override { return level > log_level_; }
+  [[nodiscard]] bool should_log(const core::logging::LOG_LEVEL level) override { return level >= log_level_; }
   [[nodiscard]] core::logging::LOG_LEVEL level() const override { return log_level_; }
 
   core::logging::LOG_LEVEL log_level_ = core::logging::LOG_LEVEL::trace;

extension-framework/cpp-extension-lib/mocklib/include/MockProcessSession.h

@@ -51,8 +51,8 @@ class MockProcessSession : public api::core::ProcessSession {
   MockProcessSession() = default;
   MockProcessSession(const MockProcessSession&) = delete;
   MockProcessSession& operator=(const MockProcessSession&) = delete;
-  MockProcessSession(const MockProcessSession&&) = delete;
-  MockProcessSession& operator=(const MockProcessSession&&) = delete;
+  MockProcessSession(MockProcessSession&&) = delete;
+  MockProcessSession& operator=(MockProcessSession&&) = delete;
 
   ~MockProcessSession() override;
 

extension-framework/cpp-extension-lib/mocklib/include/MockStreams.h

@@ -19,6 +19,7 @@
 
 #include <algorithm>
 #include <cstddef>
+#include <cstring>
 #include <span>
 #include <vector>
 

extension-framework/cpp-extension-lib/mocklib/src/mock-minifi-c.cpp

@@ -46,13 +46,13 @@ MinifiBool MinifiProcessContextHasNonEmptyProperty(MinifiProcessContext*, Minifi
 MinifiStatus MinifiProcessContextGetControllerService(MinifiProcessContext*, MinifiStringView, MinifiStringView, MinifiControllerService**) {
   throw std::runtime_error("Not implemented");
 }
-void MinifiProcessContextGetDynamicProperties(MinifiProcessContext*,
+void MinifiProcessContextGetDynamicProperties(MinifiProcessContext*, MinifiFlowFile*,
     void (*)(void* user_ctx, MinifiStringView dynamic_property_name, MinifiStringView dynamic_property_value), void*) {
   throw std::runtime_error("Not implemented");
 }
 
 MinifiStatus MinifiProcessContextGetSslData(MinifiProcessContext*, MinifiStringView,
-    void (*)(void* user_ctx, const MinifiSslData& ssl_data), void*) {
+    void (*)(void* user_ctx, const MinifiSslData* ssl_data), void*) {
   throw std::runtime_error("Not implemented");
 }