review changes

Author: martinzink

extensions/kafka/ConsumeKafka.cpp

@@ -50,7 +50,7 @@ MinifiStatus ConsumeKafka::onScheduleImpl(api::core::ProcessContext& context) {
   message_header_encoding_ = utils::parseEnumProperty<KafkaEncoding>(context, MessageHeaderEncoding);
   duplicate_header_handling_ = utils::parseEnumProperty<consume_kafka::MessageHeaderPolicyEnum>(context, DuplicateHeaderHandling);
   max_poll_time_milliseconds_ = utils::parseDurationProperty(context, MaxPollTime);
-  if (max_poll_time_milliseconds_ > 4s) {
+  if (max_poll_time_milliseconds_ >= 4s) {
     throw Exception(PROCESS_SCHEDULE_EXCEPTION, "MaxPollTime is too large (it should be less than 4s)");
   }
   max_poll_records_ = gsl::narrow<uint32_t>(utils::parseU64Property(context, MaxPollRecords));

extensions/kafka/rdkafka_utils.cpp

@@ -18,6 +18,7 @@
 #include "rdkafka_utils.h"
 
 #include <array>
+#include <vector>
 
 #include "minifi-cpp/Exception.h"
 #include "minifi-cpp/core/logging/Logger.h"

libminifi/src/minifi-c.cpp

@@ -624,10 +624,10 @@ MinifiStatus MinifiProcessContextGetSslDataFromProperty(MinifiProcessContext* pr
     const auto service_shared_ptr = context->getControllerService(*name_str, context->getProcessorInfo().getUUID());
     if (!service_shared_ptr) { return MINIFI_STATUS_VALIDATION_FAILED; }
     if (const auto ssl_context_service = dynamic_cast<minifi::controllers::SSLContextServiceInterface*>(service_shared_ptr.get())) {
-    const std::string ca_cert_file = ssl_context_service->getCACertificate().string();
-    const std::string passphrase = ssl_context_service->getPassphrase();
-    const std::string cert_file = ssl_context_service->getCertificateFile().string();
-    const std::string private_key_file = ssl_context_service->getPrivateKeyFile().string();
+      const std::string ca_cert_file = ssl_context_service->getCACertificate().string();
+      const std::string passphrase = ssl_context_service->getPassphrase();
+      const std::string cert_file = ssl_context_service->getCertificateFile().string();
+      const std::string private_key_file = ssl_context_service->getPrivateKeyFile().string();
 
       MinifiSslData ssl_data{
         .ca_certificate_file = minifiStringView(ca_cert_file),