add explanatory comments to ControllerServiceImpl.h

Author: martinzink

extension-framework/cpp-extension-lib/include/api/core/ControllerServiceImpl.h

@@ -30,6 +30,8 @@ class Connection;
 
 namespace core {
 
+/// Helper class that makes implementing the stable API easier
+/// It is used in conjunction with useControllerServiceClassDefinition
 class ControllerServiceImpl {
  public:
   explicit ControllerServiceImpl(minifi::core::ControllerServiceMetadata metadata);
@@ -42,15 +44,15 @@ class ControllerServiceImpl {
   virtual ~ControllerServiceImpl();
 
   MinifiStatus enable(ControllerServiceContext&);
-  void notifyStop();
+  void disable();
 
   [[nodiscard]] std::string getName() const;
   [[nodiscard]] minifi::utils::Identifier getUUID() const;
   [[nodiscard]] minifi::utils::SmallString<36> getUUIDStr() const;
 
  protected:
   virtual MinifiStatus enableImpl(api::core::ControllerServiceContext&) = 0;
-  virtual void notifyStopImpl() {}
+  virtual void disableImpl() {}
 
   minifi::core::ControllerServiceMetadata metadata_;
 

extension-framework/cpp-extension-lib/include/api/core/Resource.h

@@ -181,7 +181,7 @@ void useControllerServiceClassDefinition(Fn&& fn) {
           },
           .disable = [](void* self) -> void {
             try {
-              static_cast<Class*>(self)->notifyStop();
+              static_cast<Class*>(self)->disable();
             } catch (...) {}
           },
       }};