Skip to content

Commit b7ce7e9

Browse files
committed
minifi_processor_class_definition -> minifi_processor_definition
minifi_controller_service_class_definition -> minifi_controller_service_definition MINIFI_PROXY_CONFIGURATION_SERVICE_PROPERTY_TYPE -> MINIFI_PROXY_CONFIGURATION_SERVICE_INTERFACE_PROPERTY_TYPE MINIFI_SSL_CONTEXT_SERVICE_PROPERTY_TYPE -> MINIFI_SSL_CONTEXT_SERVICE_INTERFACE_PROPERTY_TYPE
1 parent e11293c commit b7ce7e9

11 files changed

Lines changed: 26 additions & 26 deletions

File tree

Extensions.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ extern "C" void minifi_init_extension(minifi_extension_context* extension_contex
4848
.user_data = nullptr
4949
};
5050
auto* extension = minifi_register_extension(extension_context, &extension_definition);
51-
minifi::api::core::useProcessorClassDefinition<minifi::extensions::llamacpp::processors::RunLlamaCppInference>([&] (const minifi_processor_class_definition& definition) {
51+
minifi::api::core::useProcessorClassDefinition<minifi::extensions::llamacpp::processors::RunLlamaCppInference>([&] (const minifi_processor_definition& definition) {
5252
minifi_register_processor(extension, &definition);
5353
});
5454
}

extension-framework/cpp-extension-lib/include/api/core/Resource.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ void useProcessorClassDefinition(Fn&& fn) {
7878
attribute_relationships_cache.push_back(std::move(rel_cache));
7979
}
8080

81-
minifi_processor_class_definition definition{
81+
minifi_processor_definition definition{
8282
.full_name = utils::minifiStringView(full_name),
8383
.description = utils::minifiStringView(Class::Description),
8484
.properties_count = gsl::narrow<uint32_t>(class_properties.size()),
@@ -149,7 +149,7 @@ void useControllerServiceClassDefinition(Fn&& fn) {
149149
}
150150
}
151151

152-
minifi_controller_service_class_definition definition{.full_name = utils::minifiStringView(full_name),
152+
minifi_controller_service_definition definition{.full_name = utils::minifiStringView(full_name),
153153
.description = utils::minifiStringView(Class::Description),
154154
.properties_count = gsl::narrow<uint32_t>(class_properties.size()),
155155
.properties_ptr = class_properties.data(),
@@ -198,14 +198,14 @@ void useControllerServiceClassDefinition(Fn&& fn) {
198198

199199
template <typename... Processors>
200200
void registerProcessors(minifi_extension* extension) {
201-
(core::useProcessorClassDefinition<Processors>([&](const minifi_processor_class_definition& definition) {
201+
(core::useProcessorClassDefinition<Processors>([&](const minifi_processor_definition& definition) {
202202
minifi_register_processor(extension, &definition);
203203
}), ...);
204204
}
205205

206206
template <typename... ControllerServices>
207207
void registerControllerServices(minifi_extension* extension) {
208-
(core::useControllerServiceClassDefinition<ControllerServices>([&](const minifi_controller_service_class_definition& definition) {
208+
(core::useControllerServiceClassDefinition<ControllerServices>([&](const minifi_controller_service_definition& definition) {
209209
minifi_register_controller_service(extension, &definition);
210210
}), ...);
211211
}

extension-framework/cpp-extension-lib/libtest/CProcessorTestUtils.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ template<typename T, typename... Args>
3232
std::unique_ptr<minifi::core::Processor> make_custom_c_processor(minifi::core::ProcessorMetadata metadata,
3333
Args&&... args) { // NOLINT(cppcoreguidelines-missing-std-forward)
3434
std::unique_ptr<minifi::core::ProcessorApi> processor_impl;
35-
minifi::api::core::useProcessorClassDefinition<T>([&](const minifi_processor_class_definition& definition) {
35+
minifi::api::core::useProcessorClassDefinition<T>([&](const minifi_processor_definition& definition) {
3636
minifi::utils::useCProcessorClassDescription(definition, [&](const auto&, auto c_description) {
3737
processor_impl = std::make_unique<minifi::utils::CProcessor>(std::move(c_description), metadata, new T(metadata, std::forward<Args>(args)...));
3838
});
@@ -44,7 +44,7 @@ template<typename T, typename... Args>
4444
std::shared_ptr<minifi::core::controller::ControllerService> make_custom_c_controller_service(minifi::core::ControllerServiceMetadata metadata,
4545
Args&&... args) { // NOLINT(cppcoreguidelines-missing-std-forward)
4646
std::unique_ptr<minifi::core::controller::ControllerServiceApi> controller_service_impl;
47-
minifi::api::core::useControllerServiceClassDefinition<T>([&](const minifi_controller_service_class_definition& definition) {
47+
minifi::api::core::useControllerServiceClassDefinition<T>([&](const minifi_controller_service_definition& definition) {
4848
minifi::utils::useCControllerServiceClassDescription("test_bundle", definition, [&](const auto&, auto c_description) {
4949
controller_service_impl = std::make_unique<minifi::utils::CControllerService>(std::move(c_description),
5050
metadata,

extension-framework/cpp-extension-lib/mocklib/src/mock-minifi-api.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,11 @@ minifi_extension* MINIFI_REGISTER_EXTENSION_FN(minifi_extension_context*, const
2424
throw std::runtime_error("Not implemented");
2525
}
2626

27-
minifi_status minifi_register_processor(minifi_extension*, const minifi_processor_class_definition*) {
27+
minifi_status minifi_register_processor(minifi_extension*, const minifi_processor_definition*) {
2828
throw std::runtime_error("Not implemented");
2929
}
3030

31-
minifi_status minifi_register_controller_service(minifi_extension*, const minifi_controller_service_class_definition*) {
31+
minifi_status minifi_register_controller_service(minifi_extension*, const minifi_controller_service_definition*) {
3232
throw std::runtime_error("Not implemented");
3333
}
3434

extensions/gcp/processors/GCSProcessor.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ class GCSProcessor : public api::core::ProcessorImpl {
5353
.build();
5454
EXTENSIONAPI static constexpr auto ProxyConfigurationService = core::PropertyDefinitionBuilder<>::createProperty("Proxy Configuration Service")
5555
.withDescription("Specifies the Proxy Configuration Controller Service to proxy network requests.")
56-
.withAllowedType<MINIFI_PROXY_CONFIGURATION_SERVICE_PROPERTY_TYPE>()
56+
.withAllowedType<MINIFI_PROXY_CONFIGURATION_SERVICE_INTERFACE_PROPERTY_TYPE>()
5757
.build();
5858
EXTENSIONAPI static constexpr auto Properties = std::to_array<core::PropertyReference>({
5959
GCPCredentials,

extensions/kafka/KafkaProcessorBase.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ class KafkaProcessorBase : public api::core::ProcessorImpl {
4141
EXTENSIONAPI static constexpr auto SSLContextService =
4242
core::PropertyDefinitionBuilder<>::createProperty("SSL Context Service")
4343
.withDescription("SSL Context Service Name")
44-
.withAllowedType<MINIFI_SSL_CONTEXT_SERVICE_PROPERTY_TYPE>()
44+
.withAllowedType<MINIFI_SSL_CONTEXT_SERVICE_INTERFACE_PROPERTY_TYPE>()
4545
.build();
4646
EXTENSIONAPI static constexpr auto SecurityProtocol =
4747
core::PropertyDefinitionBuilder<magic_enum::enum_count<kafka::SecurityProtocolOption>()>::createProperty(

libminifi/include/utils/CControllerService.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ class CControllerService final : public core::controller::ControllerServiceApi,
111111
minifi::core::ControllerServiceMetadata metadata_;
112112
};
113113

114-
void useCControllerServiceClassDescription(std::string_view bundle_name, const minifi_controller_service_class_definition& class_description,
114+
void useCControllerServiceClassDescription(std::string_view bundle_name, const minifi_controller_service_definition& class_description,
115115
const std::function<void(const ClassDescription&, CControllerServiceClassDescription)>& fn);
116116

117117
} // namespace org::apache::nifi::minifi::utils

libminifi/include/utils/CProcessor.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,6 @@ class CProcessor : public minifi::core::ProcessorApi {
177177
std::vector<minifi::state::PublishedMetric> reported_metrics_;
178178
};
179179

180-
void useCProcessorClassDescription(const minifi_processor_class_definition& class_description, const std::function<void(ClassDescription, CProcessorClassDescription)>& fn);
180+
void useCProcessorClassDescription(const minifi_processor_definition& class_description, const std::function<void(ClassDescription, CProcessorClassDescription)>& fn);
181181

182182
} // namespace org::apache::nifi::minifi::utils

libminifi/src/minifi-api.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ minifi_proxy_type minifiProxyType(const minifi::controllers::ProxyType& proxy_ty
194194

195195
namespace org::apache::nifi::minifi::utils {
196196

197-
void useCProcessorClassDescription(const minifi_processor_class_definition& class_description, const std::function<void(minifi::ClassDescription, minifi::utils::CProcessorClassDescription)>& fn) {
197+
void useCProcessorClassDescription(const minifi_processor_definition& class_description, const std::function<void(minifi::ClassDescription, minifi::utils::CProcessorClassDescription)>& fn) {
198198
std::vector<minifi::core::Property> properties;
199199
properties.reserve(class_description.properties_count);
200200
for (size_t i = 0; i < class_description.properties_count; ++i) {
@@ -265,7 +265,7 @@ void useCProcessorClassDescription(const minifi_processor_class_definition& clas
265265
fn(description, c_class_description);
266266
}
267267

268-
void useCControllerServiceClassDescription(const std::string_view bundle_name, const minifi_controller_service_class_definition& class_description,
268+
void useCControllerServiceClassDescription(const std::string_view bundle_name, const minifi_controller_service_definition& class_description,
269269
const std::function<void(const ClassDescription&, CControllerServiceClassDescription)>& fn) {
270270
std::vector<minifi::core::Property> properties;
271271
properties.reserve(class_description.properties_count);
@@ -321,7 +321,7 @@ minifi_extension* minifi_register_extension(minifi_extension_context* extension_
321321
return nullptr;
322322
}
323323

324-
minifi_status minifi_register_processor(minifi_extension* extension, const minifi_processor_class_definition* processor) {
324+
minifi_status minifi_register_processor(minifi_extension* extension, const minifi_processor_definition* processor) {
325325
gsl_Assert(extension);
326326
gsl_Assert(processor);
327327
auto* extension_ = reinterpret_cast<minifi::core::extension::Extension*>(extension);
@@ -344,7 +344,7 @@ minifi_status minifi_register_processor(minifi_extension* extension, const minif
344344
return MINIFI_STATUS_SUCCESS;
345345
}
346346

347-
minifi_status minifi_register_controller_service(minifi_extension* extension, const minifi_controller_service_class_definition* controller_service) {
347+
minifi_status minifi_register_controller_service(minifi_extension* extension, const minifi_controller_service_definition* controller_service) {
348348
gsl_Assert(extension);
349349
gsl_Assert(controller_service);
350350
auto extension_info = reinterpret_cast<minifi::core::extension::Extension*>(extension)->getInfo();

libminifi/test/integration/extension-verification-test/CApiExtension.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ CEXTENSIONAPI void minifi_init_extension(minifi_extension_context* extension_con
5050
.user_data = nullptr
5151
};
5252
auto extension = minifi_register_extension(extension_context, &extension_definition);
53-
minifi::api::core::useProcessorClassDefinition<DummyCProcessor>([&] (const minifi_processor_class_definition& definition) {
53+
minifi::api::core::useProcessorClassDefinition<DummyCProcessor>([&] (const minifi_processor_definition& definition) {
5454
minifi_register_processor(extension, &definition);
5555
});
5656
}

0 commit comments

Comments
 (0)