review changes

martinzink · martinzink · commit d23b6b8bfa23 · 2026-05-28T16:54:48.000+02:00
diff --git a/extension-framework/cpp-extension-lib/mocklib/src/MockProcessSession.cpp b/extension-framework/cpp-extension-lib/mocklib/src/MockProcessSession.cpp
@@ -22,8 +22,7 @@
 namespace org::apache::nifi::minifi::mock {
 
 api::core::FlowFile MockProcessSession::create(const api::core::FlowFile*) {
-  auto new_ff = api::core::FlowFile{new MinifiFlowFile};  // NOLINT(clang-analyzer-cplusplus.NewDeleteLeaks)
-  return new_ff;
+  return api::core::FlowFile{new MinifiFlowFile};
 }
 api::core::FlowFile MockProcessSession::get() {
   if (input_flow_files_.empty()) { return nullptr; }

Original file line number	Diff line number	Diff line change
`@@ -22,8 +22,7 @@`
`22`	`22`	`namespace org::apache::nifi::minifi::mock {`
`23`	`23`
`24`	`24`	`api::core::FlowFile MockProcessSession::create(const api::core::FlowFile*) {`
`25`		`- auto new_ff = api::core::FlowFile{new MinifiFlowFile}; // NOLINT(clang-analyzer-cplusplus.NewDeleteLeaks)`
`26`		`- return new_ff;`
	`25`	`+ return api::core::FlowFile{new MinifiFlowFile};`
`27`	`26`	`}`
`28`	`27`	`api::core::FlowFile MockProcessSession::get() {`
`29`	`28`	`if (input_flow_files_.empty()) { return nullptr; }`