MINIFICPP-2769 Move Kafka Extension to stable C API by martinzink · Pull Request #2175 · apache/nifi-minifi-cpp

martinzink · 2026-05-14T11:39:03Z

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?

For code changes:

If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE file?
If applicable, have you updated the NOTICE file?

For documentation related changes:

Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

martinzink · 2026-05-14T11:41:33Z

 namespace org::apache::nifi::minifi::processors {
-// The upper limit for Max Poll Time is 4 seconds. This is because Watchdog would potentially start
-// reporting issues with the processor health otherwise
-bool consume_kafka::ConsumeKafkaMaxPollTimePropertyValidator::validate(const std::string_view input) const {


Removed this custom validator (because C Api only supports standard validators ATM), and added a custom validation into onSchedule

martinzink · 2026-05-14T11:43:08Z

-}
-
-namespace {
-void rebalance_cb(rd_kafka_t* rk, rd_kafka_resp_err_t trigger, rd_kafka_topic_partition_list_t* partitions, void* /*opaque*/) {


I've moved this rebalence_cb into a helper class thats available through an opaque handle (needed for logging which is not available anymore through statis functions)
https://github.com/apache/nifi-minifi-cpp/pull/2175/changes#diff-93908b3b2326640601fa590e78c35c046654a1ac90c6bf70dcd7dd1bcf0d2c5cR73

martinzink · 2026-05-14T11:43:58Z

  setKafkaConfigurationField(*conf_, "isolation.level", utils::parseBoolProperty(context, HonorTransactions) ? "read_committed" : "read_uncommitted");
  setKafkaConfigurationField(*conf_, "group.id", utils::parseProperty(context, GroupID));
-  setKafkaConfigurationField(*conf_, "client.id", this->getUUIDStr());
+  // setKafkaConfigurationField(*conf_, "client.id", client_id); No need to set id since its autogenerated, and we don't access it anywhere from minifi


We dont have access to the processor's UUID, but this seems unnessary anyways, any other ideas are welcome :D

martinzink · 2026-05-14T11:44:41Z

  topics_[topicName] = topic;
 }

-void KafkaConnection::logCallback(const rd_kafka_t* rk, const int level, const char* /*fac*/, const char* buf) {


This is also been moved into KafkaOpaque class https://github.com/apache/nifi-minifi-cpp/pull/2175/changes#diff-93908b3b2326640601fa590e78c35c046654a1ac90c6bf70dcd7dd1bcf0d2c5cR46

Copilot

Pull request overview

This PR migrates the Kafka extension (and some related extension infrastructure) toward the stable C API / cpp-extension-lib surface by refactoring processor implementations to api::core::* interfaces, switching extension registration to the C-API initializer path, and adjusting supporting utilities/tests accordingly.

Changes:

Rename/process-context SSL data C API entry point and wire it through the CFFI ProcessContext wrapper.
Refactor Kafka processors (PublishKafka/ConsumeKafka) to api::core::{ProcessContext,ProcessSession} and introduce KafkaOpaque for librdkafka callbacks/logging.
Update extension initializers/CMake targets (Kafka + LlamaCpp) and modernize Kafka tests to use the mock C-API framework.

Reviewed changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
minifi-api/minifi-c-api.def	Updates exported C API symbol list for SSL data retrieval.
minifi-api/include/minifi-c/minifi-c.h	Renames the SSL data retrieval C API declaration.
libminifi/src/minifi-c.cpp	Implements renamed SSL data retrieval function by resolving controller service name from a property.
extensions/llamacpp/processors/RunLlamaCppInference.cpp	Switches to `parseOptionalProperty` helper for optional property parsing.
extensions/llamacpp/ExtensionInitializer.cpp	Updates include path and registers processors via C API extension initializer helper.
extensions/llamacpp/CMakeLists.txt	Ensures `ExtensionInitializer.cpp` is part of the build sources.
extensions/kafka/tests/PublishKafkaTests.cpp	Replaces legacy test harness with mock C-API process context/session based tests.
extensions/kafka/tests/CMakeLists.txt	Updates test linking/runtime output settings for the new test approach.
extensions/kafka/rdkafka_utils.h	Refactors utilities and introduces `KafkaOpaque` for callbacks; updates includes/types.
extensions/kafka/rdkafka_utils.cpp	Implements `KafkaOpaque` log + rebalance callbacks and topic list debug printing.
extensions/kafka/PublishKafka.h	Migrates processor interface to `api::core` and updates SSL/type handling.
extensions/kafka/PublishKafka.cpp	Migrates scheduling/triggering/session interactions to `api::core` and updates config callbacks.
extensions/kafka/KafkaProcessorBase.h	Migrates base class to `api::core::ProcessorImpl` and updates SSL property allowed type.
extensions/kafka/KafkaProcessorBase.cpp	Reworks SSL retrieval and authentication parameter setup for the new API surface.
extensions/kafka/KafkaConnection.h	Removes legacy logger plumbing and static log callback approach.
extensions/kafka/KafkaConnection.cpp	Removes legacy logger mapping/callback implementation.
extensions/kafka/ExtensionInitializer.cpp	Adds C API extension initializer registering Kafka processors.
extensions/kafka/ConsumeKafka.h	Migrates processor interface to `api::core`, updates validator usage, refactors helper signatures.
extensions/kafka/ConsumeKafka.cpp	Migrates scheduling/triggering/session interactions to `api::core` and updates callbacks/config handling.
extensions/kafka/CMakeLists.txt	Renames the extension library target and registers it as a C-API extension.
extension-framework/cpp-extension-lib/src/core/ProcessContext.cpp	Routes SSL retrieval through the renamed C API function.
extension-framework/cpp-extension-lib/mocklib/src/mock-minifi-c.cpp	Updates mocked symbol name and wraps exports in `extern "C"`.
extension-framework/cpp-extension-lib/mocklib/CMakeLists.txt	Renames mock library target to `mock-minifi`.
core-framework/common/include/core/PropertyDefinitionBuilder.h	Adds string-literal-based `withAllowedType()` support for stable allowed-type storage.
CMakeLists.txt	Updates default-enabled extension name from the old Kafka target to the new one.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 28 out of 28 changed files in this pull request and generated 4 comments.

martinzink commented May 14, 2026

View reviewed changes

martinzink requested a review from Copilot May 14, 2026 11:45

Copilot started reviewing on behalf of martinzink May 14, 2026 11:45 View session

Copilot AI reviewed May 14, 2026

View reviewed changes

martinzink force-pushed the kafka_c_api_new branch 2 times, most recently from 2878fa2 to 527195a Compare May 14, 2026 14:28

martinzink requested a review from Copilot May 14, 2026 16:11

Copilot started reviewing on behalf of martinzink May 14, 2026 16:12 View session

martinzink added depends-on-another-PR c-api labels May 14, 2026

martinzink marked this pull request as ready for review May 14, 2026 16:15

Copilot AI reviewed May 14, 2026

View reviewed changes

Comment thread libminifi/src/minifi-c.cpp Outdated

Comment thread extensions/kafka/ConsumeKafka.cpp Outdated

Comment thread extensions/kafka/rdkafka_utils.cpp

Comment thread extensions/kafka/PublishKafka.cpp

adamdebreceni self-requested a review May 14, 2026 16:36

szaszm self-requested a review May 21, 2026 13:41

martinzink force-pushed the MINIFICPP-2798 branch from 97edf58 to e4f700e Compare May 27, 2026 07:20

martinzink force-pushed the kafka_c_api_new branch from 527195a to cf8d253 Compare May 27, 2026 07:24

martinzink force-pushed the MINIFICPP-2798 branch from e4f700e to c9060a8 Compare May 27, 2026 15:11

martinzink force-pushed the kafka_c_api_new branch from 208447e to 1985dd0 Compare May 27, 2026 15:15

martinzink force-pushed the MINIFICPP-2798 branch 2 times, most recently from 4d18c0d to 0a3ae8b Compare May 28, 2026 11:29

martinzink and others added 4 commits May 28, 2026 13:55

MINIFICPP-2769 Move Kafka Extension to stable C API

93b52de

review changes

7ce6d56

kafka part

a3bd0fc

fix kafka docker

19d57ec

martinzink force-pushed the kafka_c_api_new branch from 1985dd0 to 19d57ec Compare May 28, 2026 11:55

martinzink added 2 commits May 28, 2026 15:52

update manifest

69005c2

clang-tidy workarounds

7e096a9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MINIFICPP-2769 Move Kafka Extension to stable C API#2175

MINIFICPP-2769 Move Kafka Extension to stable C API#2175
martinzink wants to merge 6 commits into
apache:MINIFICPP-2798from
martinzink:kafka_c_api_new

martinzink commented May 14, 2026

Uh oh!

martinzink May 14, 2026

Uh oh!

martinzink May 14, 2026

Uh oh!

martinzink May 14, 2026

Uh oh!

martinzink May 14, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

martinzink commented May 14, 2026

For all changes:

For code changes:

For documentation related changes:

Note:

Uh oh!

martinzink May 14, 2026

Choose a reason for hiding this comment

Uh oh!

martinzink May 14, 2026

Choose a reason for hiding this comment

Uh oh!

martinzink May 14, 2026

Choose a reason for hiding this comment

Uh oh!

martinzink May 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants