Skip to content

Commit ddabe96

Browse files
NUTCH-3144 URLUtil unit tests fail after upgrade to crawler-commons 1.6
- adapt unit tests to changes introduced in crawler-commons/crawler-commons#478 - test for example given in Javadoc of getDomainSuffix
1 parent 8e7bbc4 commit ddabe96

2 files changed

Lines changed: 3 additions & 1 deletion

File tree

src/java/org/apache/nutch/util/URLUtil.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,7 @@ public static String getDomainSuffix(URL url) {
262262

263263
EffectiveTldFinder.EffectiveTLD suffix = EffectiveTldFinder.getEffectiveTLD(host, true);
264264
if (suffix != null) {
265-
return suffix.getDomain();
265+
return suffix.getSuffix();
266266
}
267267

268268
return null;

src/test/org/apache/nutch/util/TestURLUtil.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,8 @@ public void testGetDomainSuffix() throws Exception {
147147
assertEquals("2000.hu", URLUtil.getDomainSuffix(url));
148148

149149
// test non-ASCII
150+
url = new URL("https://www.taiuru.māori.nz/");
151+
assertEquals("xn--mori-qsa.nz", URLUtil.getDomainSuffix(url));
150152
url = new URL("http://www.example.flå.no");
151153
assertEquals("xn--fl-zia.no", URLUtil.getDomainSuffix(url));
152154
url = new URL("http://www.example.栃木.jp");

0 commit comments

Comments
 (0)