Skip to content

Commit 10b3cf1

Browse files
linguini1Biancaa Ramesh
authored andcommitted
!interpreters/minibasic: Align naming of configuration options
Aligns `CONFIG_INTERPRETER_*` options to `CONFIG_INTERPRETERS_*` options to be consistent with other interpreters. BREAKING CHANGE: All configurations using `CONFIG_INTERPRETER_MINIBASIC_*` options will no longer compile due to missing symbol errors. The fix is very quick: any configurations using this options should add a trailing S following INTERPRETER in the affected Kconfig variables. I believe `./tools/refresh.sh` should also be capable of doing this automatically. Signed-off-by: Matteo Golin <matteo.golin@gmail.com>
1 parent 0a551ad commit 10b3cf1

5 files changed

Lines changed: 13 additions & 13 deletions

File tree

interpreters/minibasic/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ if(CONFIG_INTERPRETERS_MINIBASIC)
2828
script.c
2929
basic.c
3030
STACKSIZE
31-
${CONFIG_INTERPRETER_MINIBASIC_STACKSIZE}
31+
${CONFIG_INTERPRETERS_MINIBASIC_STACKSIZE}
3232
PRIORITY
33-
${CONFIG_INTERPRETER_MINIBASIC_PRIORITY})
33+
${CONFIG_INTERPRETERS_MINIBASIC_PRIORITY})
3434
endif()

interpreters/minibasic/Kconfig

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,25 +33,25 @@ config INTERPRETERS_MINIBASIC
3333

3434
if INTERPRETERS_MINIBASIC
3535

36-
config INTERPRETER_MINIBASIC_PRIORITY
36+
config INTERPRETERS_MINIBASIC_PRIORITY
3737
int "Basic interpreter priority"
3838
default 100
3939
---help---
4040
Task priority of the Basic interpreter main task
4141

42-
config INTERPRETER_MINIBASIC_STACKSIZE
42+
config INTERPRETERS_MINIBASIC_STACKSIZE
4343
int "Basic interpreter stack size"
4444
default 4096
4545
---help---
4646
Size of the stack allocated for the Basic interpreter main task
4747

48-
config INTERPRETER_MINIBASIC_IOBUFSIZE
48+
config INTERPRETERS_MINIBASIC_IOBUFSIZE
4949
int "I/O buffer size"
5050
default 1024
5151
---help---
5252
Size of the statically allocated I/O buffer.
5353

54-
config INTERPRETER_MINIBASIC_TESTSCRIPT
54+
config INTERPRETERS_MINIBASIC_TESTSCRIPT
5555
bool "Test script"
5656
default n
5757
---help---

interpreters/minibasic/Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ MAINSRC = script.c
3131
# Mini Basic built-in application info
3232

3333
PROGNAME = basic
34-
PRIORITY = $(CONFIG_INTERPRETER_MINIBASIC_PRIORITY)
35-
STACKSIZE = $(CONFIG_INTERPRETER_MINIBASIC_STACKSIZE)
34+
PRIORITY = $(CONFIG_INTERPRETERS_MINIBASIC_PRIORITY)
35+
STACKSIZE = $(CONFIG_INTERPRETERS_MINIBASIC_STACKSIZE)
3636
MODULE = $(CONFIG_INTERPRETERS_MINIBASIC)
3737

3838
include $(APPDIR)/Application.mk

interpreters/minibasic/basic.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,11 @@
4848

4949
/* Configuration */
5050

51-
#ifndef CONFIG_INTERPRETER_MINIBASIC_IOBUFSIZE
52-
# define CONFIG_INTERPRETER_MINIBASIC_IOBUFSIZE 1024
51+
#ifndef CONFIG_INTERPRETERS_MINIBASIC_IOBUFSIZE
52+
# define CONFIG_INTERPRETERS_MINIBASIC_IOBUFSIZE 1024
5353
#endif
5454

55-
#define IOBUFSIZE CONFIG_INTERPRETER_MINIBASIC_IOBUFSIZE
55+
#define IOBUFSIZE CONFIG_INTERPRETERS_MINIBASIC_IOBUFSIZE
5656

5757
/* Tokens defined */
5858

interpreters/minibasic/script.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
* Private Data
4646
****************************************************************************/
4747

48-
#ifdef CONFIG_INTERPRETER_MINIBASIC_TESTSCRIPT
48+
#ifdef CONFIG_INTERPRETERS_MINIBASIC_TESTSCRIPT
4949
/* Here is a simple script to play with */
5050

5151
static FAR char *script =
@@ -147,7 +147,7 @@ int main(int argc, FAR char *argv[])
147147

148148
if (argc == 1)
149149
{
150-
#ifdef CONFIG_INTERPRETER_MINIBASIC_TESTSCRIPT
150+
#ifdef CONFIG_INTERPRETERS_MINIBASIC_TESTSCRIPT
151151
basic(script, stdin, stdout, stderr);
152152
#else
153153
fprintf(stderr, "ERROR: Missing argument.\n");

0 commit comments

Comments
 (0)