boards/arm/stm32f4: drop duplicated STM32_ROMFS, use common board logic

stm32f4discovery, nucleo-f446re and omnibusf4 each declared their own
STM32_ROMFS Kconfig options and carried a near-identical copy of
stm32_romfs_initialize.c.

Signed-off-by: raiden00pl <raiden00@railab.me>

Author: raiden00pl

boards/arm/stm32f4/nucleo-f446re/Kconfig

@@ -30,26 +30,4 @@ config NUCLEO_F446RE_AJOY_MINBUTTONS
 		minimal set:  SELECT (joystick down), FIRE (BUTTON B), and JUMP
 		(BUTTON A).
 
-config STM32_ROMFS
-	bool "Automount baked-in ROMFS image"
-	default n
-	depends on FS_ROMFS
-	---help---
-		Select STM32_ROMFS_IMAGEFILE, STM32_ROMFS_DEV_MINOR, STM32_ROMFS_MOUNTPOINT
-
-config STM32_ROMFS_DEV_MINOR
-	int "Minor for the block device backing the data"
-	depends on STM32_ROMFS
-	default 64
-
-config STM32_ROMFS_MOUNTPOINT
-	string "Mountpoint of the custom romfs image"
-	depends on STM32_ROMFS
-	default "/rom"
-
-config STM32_ROMFS_IMAGEFILE
-	string "ROMFS image file to include into build"
-	depends on STM32_ROMFS
-	default "../../../rom.img"
-
 endif # ARCH_BOARD_NUCLEO_F446RE

boards/arm/stm32f4/nucleo-f446re/src/CMakeLists.txt

@@ -70,10 +70,6 @@ if(CONFIG_BOARD_STM32_IHM08M1)
   list(APPEND SRCS stm32_foc_ihm08m1.c)
 endif()
 
-if(CONFIG_STM32_ROMFS)
-  list(APPEND SRCS stm32_romfs_initialize.c)
-endif()
-
 target_sources(board PRIVATE ${SRCS})
 
 set_property(GLOBAL PROPERTY LD_SCRIPT "${NUTTX_BOARD_DIR}/scripts/f446re.ld")

boards/arm/stm32f4/nucleo-f446re/src/Make.defs

@@ -72,10 +72,6 @@ ifeq ($(CONFIG_BOARD_STM32_IHM08M1),y)
 CSRCS += stm32_foc_ihm08m1.c
 endif
 
-ifeq ($(CONFIG_STM32_ROMFS),y)
-CSRCS += stm32_romfs_initialize.c
-endif
-
 DEPPATH += --dep-path board
 VPATH += :board
 CFLAGS += ${INCDIR_PREFIX}$(TOPDIR)$(DELIM)arch$(DELIM)$(CONFIG_ARCH)$(DELIM)src$(DELIM)board$(DELIM)board

boards/arm/stm32f4/nucleo-f446re/src/stm32_bringup.c

@@ -64,7 +64,9 @@
 #  include <nuttx/leds/userled.h>
 #endif
 
-#include "stm32_romfs.h"
+#ifdef CONFIG_STM32_ROMFS
+#  include "stm32_romfs.h"
+#endif
 #include "nucleo-f446re.h"
 
 /****************************************************************************

boards/arm/stm32f4/nucleo-f446re/src/stm32_romfs.h

@@ -5,26 +5,4 @@
 
 if ARCH_BOARD_OMNIBUSF4
 
-config STM32_ROMFS
-	bool "Automount baked-in ROMFS image"
-	default n
-	depends on FS_ROMFS
-	---help---
-		Select STM32_ROMFS_IMAGEFILE, STM32_ROMFS_DEV_MINOR, STM32_ROMFS_MOUNTPOINT
-
-config STM32_ROMFS_DEV_MINOR
-	int "Minor for the block device backing the data"
-	depends on STM32_ROMFS
-	default 64
-
-config STM32_ROMFS_MOUNTPOINT
-	string "Mountpoint of the custom romfs image"
-	depends on STM32_ROMFS
-	default "/rom"
-
-config STM32_ROMFS_IMAGEFILE
-	string "ROMFS image file to include into build"
-	depends on STM32_ROMFS
-	default "../../../rom.img"
-
 endif

boards/arm/stm32f4/nucleo-f446re/src/stm32_romfs_initialize.c

@@ -62,10 +62,6 @@ if(CONFIG_TIMER)
   list(APPEND SRCS stm32_timer.c)
 endif()
 
-if(CONFIG_STM32_ROMFS)
-  list(APPEND SRCS stm32_romfs_initialize.c)
-endif()
-
 if(CONFIG_BOARDCTL_UNIQUEID)
   list(APPEND SRCS stm32_uid.c)
 endif()

boards/arm/stm32f4/omnibusf4/Kconfig

@@ -63,10 +63,6 @@ ifeq ($(CONFIG_TIMER),y)
 CSRCS += stm32_timer.c
 endif
 
-ifeq ($(CONFIG_STM32_ROMFS),y)
-CSRCS += stm32_romfs_initialize.c
-endif
-
 ifeq ($(CONFIG_BOARDCTL_UNIQUEID),y)
 CSRCS += stm32_uid.c
 endif

boards/arm/stm32f4/omnibusf4/src/CMakeLists.txt

@@ -38,7 +38,9 @@
 #endif
 
 #include "stm32.h"
-#include "stm32_romfs.h"
+#ifdef CONFIG_STM32_ROMFS
+#  include "stm32_romfs.h"
+#endif
 
 #ifdef CONFIG_STM32_OTGFS
 #  include "stm32_usbhost.h"