boards/xtensa/esp32s3: New board WaveShare ESP32-S3-(Touch)-LCD-1.28.#18730
Conversation
eren-terzioglu
left a comment
There was a problem hiding this comment.
Thanks for adding new esp based board. Nice work, congrats
|
Thank you @cederom! |
ea2b297 to
185263d
Compare
|
Updated, thank you for checking folks! :-) Ah, typos and formatting, will update in few hours, have to go out now, sorry! <3 |
185263d to
7047971
Compare
dfcbeaa to
d3e2ba7
Compare
d3e2ba7 to
6e1ebf0
Compare
|
Hi @cederom It looks like a problem related to defconfig |
Thank you @simbit18 will regenerate defconfigs and push again! :-) Before that I just want to clarify with WaveShare the pinouts because schematics and pictures on their website are inconsistent.. schematics has different H2 pinouts.. and I want us to provide correct coherent information in our documentation :-)
|
6e1ebf0 to
72ee685
Compare
|
|
|
Just saw those defconfig debug options. Otherwise, looks good! Nice work! |
Thank you @fdcavalcanti good point, as these are default configurations usually used for testing it would be nice to have debug options bundled in case something goes south we will already have them included and these are really powerful chips with lots of memory so it does not hurt here :-) Custom build / project for sure can disable them to save storage when needed / on release :-) |
Well I'm more in line of having defconfigs as the minimum necessary to make the config work, debugging is up to the user. I'll keep it approved. |
|
@fdcavalcanti I have double checked, please take a look and let me know what you think, if you see another choice please suggest the implementation :-)
|
Looks good! |
…IP). * Initial experimental / work in progress implementation. * New board name is esp32s3-ws-lcd128. * Supports Kconfig delectable w/wo touch variants (lcd gpios difference). * IMU QMI8658 bringups is put into esp32s3/common/src to share with other boards. Pin defines are located at <board>include/board.h and referenced with `#include <arch/board/board.h>`. * Supported configurations: nsh, ostest, coremark, touch-lvgl, notouch-lvgl, imu-qmi8658, watchdog. * Does not have touch panel driver yet. * Created board documentation. Added sphinx inline cross-references. * TODO: Fix SPI GC9A01A LCD pixel format colors. * TODO: Create I2C CST816S touch panel driver. Signed-off-by: Tomasz 'CeDeROM' CEDRO <tomek@cedro.info>
72ee685 to
05dc836
Compare
|
Thank you @fdcavalcanti again for your time and detailed verification!! :-) Runtime verification:
|

Summary
#include <arch/board/board.h>.[1] https://www.waveshare.com/wiki/ESP32-S3-Touch-LCD-1.28
Impact
Testing
Developed on FreeBSD 14.4, provided and testes basic configurations with nsh, ostest, coremark, watchdog, touch-lvgl (spawns lvgldemo on touch board variant), notouch-lvgl (non-touch board variant lvgldemo spawn).