Fixed: String comparison (OFBIZ-13320) #926

In several locations strings are compared with == and != 
Should be compared with equals, unless they are interned. But even for
interned strings equals() is safe

Thanks: Dmitriy Kryukov

---------

Signed-off-by: Dmitry Kryukov <dk2k@ya.ru>

Author: dk2k

applications/accounting/src/main/java/org/apache/ofbiz/accounting/thirdparty/eway/GatewayResponse.java

@@ -185,7 +185,7 @@ public GatewayResponse(InputStream xmlstream, GatewayRequest req) throws Excepti
         Node rootnode = doc.getDocumentElement();
         String root = rootnode.getNodeName();
 
-        if ("ewayResponse" != root) {
+        if (!"ewayResponse".equals(root)) {
             throw new Exception("Bad root element in response: " + root);
         }
 
@@ -195,7 +195,7 @@ public GatewayResponse(InputStream xmlstream, GatewayRequest req) throws Excepti
         for (int i = 0; i < length; i++) {
             Node node = list.item(i);
             String name = node.getNodeName();
-            if ("ewayResponse" == name) {
+            if ("ewayResponse".equals(name)) {
                 continue;
             }
             Text textnode = (Text) node.getFirstChild();

framework/catalina/src/main/java/org/apache/ofbiz/catalina/container/CatalinaContainer.java

@@ -25,6 +25,7 @@
 import java.util.HashSet;
 import java.util.List;
 import java.util.Map;
+import java.util.Objects;
 import java.util.Set;
 import java.util.concurrent.Callable;
 import java.util.concurrent.Future;
@@ -260,7 +261,7 @@ private static Host prepareVirtualHost(Tomcat tomcat, List<String> virtualHosts)
         }
 
         virtualHosts.stream()
-            .filter(virtualHost -> virtualHost != hostName).forEach(virtualHost -> host.addAlias(virtualHost));
+            .filter(virtualHost -> !Objects.equals(virtualHost, hostName)).forEach(virtualHost -> host.addAlias(virtualHost));
 
         return host;
     }

framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/RequestHandler.java

@@ -1042,7 +1042,7 @@ public void doRequest(HttpServletRequest request, HttpServletResponse response,
      * @param requestResponse
      */
     private void setUserMessageResponseToRequest(HttpServletRequest request, ConfigXMLReader.RequestResponse requestResponse) {
-        final String fieldMessageName = requestResponse.getName() == "error"
+        final String fieldMessageName = "error".equals(requestResponse.getName())
                 ? "_ERROR_MESSAGE_"
                 : "_EVENT_MESSAGE_";
         final String customMessageField = "_CUSTOM" + fieldMessageName;

framework/widget/src/main/java/org/apache/ofbiz/widget/model/CommonWidgetModels.java

@@ -400,7 +400,7 @@ public Link(Element linkElement) {
                 } else {
                     Node formElement = autoFormParamsElement;
                     while (formElement != null
-                            && formElement.getLocalName() != "form") {
+                            && !"form".equals(formElement.getLocalName())) {
                         formElement = formElement.getParentNode();
                     }
                     if (formElement != null && formElement.getLocalName() != null) {

framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelForm.java

@@ -2323,7 +2323,7 @@ public UpdateArea(Element updateAreaElement, String defaultServiceName, String d
                 } else {
                     Node formElement = autoFormParamsElement;
                     while (formElement != null
-                            && formElement.getLocalName() != "form") {
+                            && !"form".equals(formElement.getLocalName())) {
                         formElement = formElement.getParentNode();
                     }
                     if (formElement != null && formElement.getLocalName() != null) {