Fixed: Correct receivedQuantity calculation in getReceivedQuantityForOrderItem by including quantityRejected

golja · golja · commit 5a7578971d91 · 2026-06-03T17:42:30.000+02:00
diff --git a/applications/product/src/main/groovy/org/apache/ofbiz/product/shipment/ShipmentReceiptServices.groovy b/applications/product/src/main/groovy/org/apache/ofbiz/product/shipment/ShipmentReceiptServices.groovy
@@ -299,6 +299,7 @@ BigDecimal getReceivedQuantityForOrderItem (GenericValue orderItem) {
     List shipmentReceipts = from('ShipmentReceipt').where(orderId: orderItem.orderId, orderItemSeqId: orderItem.orderItemSeqId).queryList()
     for (GenericValue shipmentReceipt : shipmentReceipts) {
         receivedQuantity +=  shipmentReceipt.quantityAccepted
+        receivedQuantity +=  shipmentReceipt.quantityRejected
     }
     return receivedQuantity
 }

Original file line number	Diff line number	Diff line change
`@@ -299,6 +299,7 @@ BigDecimal getReceivedQuantityForOrderItem (GenericValue orderItem) {`
`299`	`299`	`List shipmentReceipts = from('ShipmentReceipt').where(orderId: orderItem.orderId, orderItemSeqId: orderItem.orderItemSeqId).queryList()`
`300`	`300`	`for (GenericValue shipmentReceipt : shipmentReceipts) {`
`301`	`301`	`receivedQuantity += shipmentReceipt.quantityAccepted`
	`302`	`+ receivedQuantity += shipmentReceipt.quantityRejected`
`302`	`303`	`}`
`303`	`304`	`return receivedQuantity`
`304`	`305`	`}`