Ofbiz 13374 Fixed: incorrect Groovy range iteration that was causing index out of bounds (#1177)

Fixed: proper parenthesised based iteration to avoid precedence issue
that leads to invalid index access.

---------

Co-authored-by: Ankit Joshi <ankitjoshi@Ankit-Joshi.local>
Co-authored-by: Jacques Le Roux <jacques.le.roux@les7arts.com>

Thanks Ankit!

Author: Ankit-Joshi11

applications/product/src/main/groovy/org/apache/ofbiz/product/catalog/imagemanagement/ImageRecentlyApproved.groovy

@@ -18,15 +18,15 @@
 */
 package org.apache.ofbiz.product.catalog.imagemanagement
 
-import org.apache.ofbiz.entity.GenericValue
-import org.apache.ofbiz.entity.condition.EntityCondition
-import org.apache.ofbiz.entity.condition.EntityOperator
-
 import java.sql.Timestamp
 import java.text.SimpleDateFormat
 import java.time.LocalDateTime
 import java.time.format.DateTimeFormatter
 
+import org.apache.ofbiz.entity.GenericValue
+import org.apache.ofbiz.entity.condition.EntityCondition
+import org.apache.ofbiz.entity.condition.EntityOperator
+
 int limit = 13 // set number of days
 DateTimeFormatter sdf = DateTimeFormatter.ofPattern('yyyy-MM-dd HH:mm:ss')
 DateTimeFormatter sdf2 = DateTimeFormatter.ofPattern('EEEE dd/MM/yyyy', locale)
@@ -55,7 +55,7 @@ for (i in 0..limit) {
 
     List time = []
     if (tempTimeList.size > 0) {
-        0..tempTimeList.size - 1.each { j ->
+        (0..tempTimeList.size - 1).each { j ->
             time.add(sdfTime.format(tempTimeList.get(j).get(0)))
         }
     }