Fixed: Enhance error logging in ICalConverter for service invocation failures

Author: jacopoc

applications/workeffort/src/main/java/org/apache/ofbiz/workeffort/workeffort/ICalConverter.java

@@ -158,7 +158,8 @@ protected static ResponseProperties createWorkEffort(Component component, Map<St
         serviceMap.put("statusId", "PRTYASGN_ASSIGNED");
         Map<String, Object> serviceResult = invokeService("createWorkEffortAndPartyAssign", serviceMap, context);
         if (ServiceUtil.isError(serviceResult)) {
-            return ICalWorker.createPartialContentResponse(ServiceUtil.getErrorMessage(serviceResult));
+            Debug.logError("createWorkEffortAndPartyAssign service error: " + ServiceUtil.getErrorMessage(serviceResult), MODULE);
+            return ICalWorker.createPartialContentResponse(null);
         }
         String workEffortId = (String) serviceResult.get("workEffortId");
         if (workEffortId != null) {
@@ -170,7 +171,8 @@ protected static ResponseProperties createWorkEffort(Component component, Map<St
             serviceMap.put("fromDate", new Timestamp(System.currentTimeMillis()));
             serviceResult = invokeService("createWorkEffortAssoc", serviceMap, context);
             if (ServiceUtil.isError(serviceResult)) {
-                return ICalWorker.createPartialContentResponse(ServiceUtil.getErrorMessage(serviceResult));
+                Debug.logError("createWorkEffortAssoc service error: " + ServiceUtil.getErrorMessage(serviceResult), MODULE);
+                return ICalWorker.createPartialContentResponse(null);
             }
             storePartyAssignments(workEffortId, component, context);
         }
@@ -785,7 +787,8 @@ public static ResponseProperties storeCalendar(InputStream is, Map<String, Objec
             serviceResult = invokeService("updateWorkEffortICalData", serviceMap, context);
         }
         if (ServiceUtil.isError(serviceResult)) {
-            return ICalWorker.createPartialContentResponse(ServiceUtil.getErrorMessage(serviceResult));
+            Debug.logError("createWorkEffortICalData/updateWorkEffortICalData service error: " + ServiceUtil.getErrorMessage(serviceResult), MODULE);
+            return ICalWorker.createPartialContentResponse(null);
         }
         return ICalWorker.createOkResponse(null);
     }
@@ -827,7 +830,8 @@ protected static ResponseProperties storePartyAssignments(String workEffortId, C
                     invokeService("assignPartyToWorkEffort", serviceMap, context);
                 }
             } catch (GenericEntityException e) {
-                responseProps = ICalWorker.createPartialContentResponse(e.getMessage());
+                Debug.logError(e, "Error assigning party to work effort: ", MODULE);
+                responseProps = ICalWorker.createPartialContentResponse(null);
                 break;
             }
         }