Backported: remove generateSecretKeys dependency from test to improve build caching (PR #1028)#1059
Merged
Merged
Conversation
…d caching
The `test` task depends on `generateSecretKeys`, which writes new random
values to `framework/security/config/security.properties` on every
build. Since this file is part of the main resource source set
(`config/` dirs are included via
`getDirectoryInActiveComponentsIfExists('config')`), changing it causes
cascading Gradle build cache misses for:
- `:compileTestGroovy` — classpath includes main resources
- `:checkstyleMain` — classpath includes `sourceSets.main.output`
- `:checkstyleTest` — same reason
- `:test` — classpath + test classes differ
This commit:
1. Removes `dependsOn 'generateSecretKeys'` from the `test` task —
the main `security.properties` is no longer mutated during `build`
2. Adds a test-specific `security.properties` in
`framework/security/src/test/resources/` with fixed keys — this shadows
the main config on the test classpath so unit tests that require JWT
keys (e.g. `ModelFormTest`) continue to work
The `generateSecretKeys` task is unchanged and remains available for
manual use (`./gradlew generateSecretKeys`) and as a dependency of
`loadAll`.
(cherry picked from commit 73d0d37)
(cherry picked from commit 4b59bc7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.