Skip to content

Fixed: Enhance error logging in ICalConverter for service invocation failures #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacopoc merged 1 commit into from
Apr 6, 2026
Merged

Fixed: Enhance error logging in ICalConverter for service invocation failures #1062

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions ...ations/workeffort/src/main/java/org/apache/ofbiz/workeffort/workeffort/ICalConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,8 @@ protected static ResponseProperties createWorkEffort(Component component, Map<St
serviceMap.put("statusId", "PRTYASGN_ASSIGNED");
Map<String, Object> serviceResult = invokeService("createWorkEffortAndPartyAssign", serviceMap, context);
if (ServiceUtil.isError(serviceResult)) {
return ICalWorker.createPartialContentResponse(ServiceUtil.getErrorMessage(serviceResult));
Debug.logError("createWorkEffortAndPartyAssign service error: " + ServiceUtil.getErrorMessage(serviceResult), MODULE);
return ICalWorker.createPartialContentResponse(null);
}
String workEffortId = (String) serviceResult.get("workEffortId");
if (workEffortId != null) {
Expand All @@ -170,7 +171,8 @@ protected static ResponseProperties createWorkEffort(Component component, Map<St
serviceMap.put("fromDate", new Timestamp(System.currentTimeMillis()));
serviceResult = invokeService("createWorkEffortAssoc", serviceMap, context);
if (ServiceUtil.isError(serviceResult)) {
return ICalWorker.createPartialContentResponse(ServiceUtil.getErrorMessage(serviceResult));
Debug.logError("createWorkEffortAssoc service error: " + ServiceUtil.getErrorMessage(serviceResult), MODULE);
return ICalWorker.createPartialContentResponse(null);
}
storePartyAssignments(workEffortId, component, context);
}
Expand Down Expand Up @@ -785,7 +787,8 @@ public static ResponseProperties storeCalendar(InputStream is, Map<String, Objec
serviceResult = invokeService("updateWorkEffortICalData", serviceMap, context);
}
if (ServiceUtil.isError(serviceResult)) {
return ICalWorker.createPartialContentResponse(ServiceUtil.getErrorMessage(serviceResult));
Debug.logError("createWorkEffortICalData/updateWorkEffortICalData service error: " + ServiceUtil.getErrorMessage(serviceResult), MODULE);
return ICalWorker.createPartialContentResponse(null);
}
return ICalWorker.createOkResponse(null);
}
Expand Down Expand Up @@ -827,7 +830,8 @@ protected static ResponseProperties storePartyAssignments(String workEffortId, C
invokeService("assignPartyToWorkEffort", serviceMap, context);
}
} catch (GenericEntityException e) {
responseProps = ICalWorker.createPartialContentResponse(e.getMessage());
Debug.logError(e, "Error assigning party to work effort: ", MODULE);
responseProps = ICalWorker.createPartialContentResponse(null);
break;
}
}
Expand Down
Loading