Skip to content

Fixed: Derive servlet path from trusted _CONTROL_PATH_ request attribute #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacopoc merged 1 commit into from
Apr 7, 2026
Merged

Fixed: Derive servlet path from trusted _CONTROL_PATH_ request attribute #1068

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/RequestHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1418,7 +1418,12 @@ public String makeLink(HttpServletRequest request, HttpServletResponse response,

//If required by webSite parameter, surcharge control path
if (webSiteProps.getWebappPath() != null) {
String requestPath = request.getServletPath();
// Derive servlet path from the trusted _CONTROL_PATH_ request attribute (set by ControlServlet)
// rather than calling getServletPath() directly on the request, to avoid relying on user-influenced input.
String contextPath = request.getContextPath();
String requestPath = controlPath.startsWith(contextPath)
? controlPath.substring(contextPath.length())
: controlPath;
if (requestPath == null) requestPath = "";
if (requestPath.lastIndexOf("/") > 0) {
if (requestPath.indexOf("/") == 0) {
Expand Down
Loading