Fixed issue in reCreateOrderAdjustment service on adding promo item after cancel order item request.#1137
Merged
Conversation
…om order. On adding new promo item after cancelling it was creating only orderItem record while we need to map that item with orderItemShipGroup using ship group assocs. So added support to create ship group assoc whenever it creats new item due to promotion.[OFBIZ-12104]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed: After cancelling it was creating only orderItem record while we need to map that item with orderItemShipGroup using ship group assocs. So added support to create ship group assoc whenever it creats new item due to promotion.[OFBIZ-12104]
(OFBIZ-12104)
Thanks: Rashi Dhagat for reporting the issue and providing details.