Skip to content

Fixed issue in reCreateOrderAdjustment service on adding promo item after cancel order item request. #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arunpati merged 1 commit into from
Apr 28, 2026
Merged

Fixed issue in reCreateOrderAdjustment service on adding promo item after cancel order item request. #1137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion applications/order/minilang/order/OrderServices.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,10 +384,35 @@ under the License.
<set field="newOrderItem.isModifiedPrice" value="N"/>
<set field="newOrderItem.isPromo" value="Y"/>
<if-empty field="newOrderItem.statusId">
<set field="newOrderItem.statusId" value="ITEM_CREATED"/>
<if-compare field="order.statusId" operator="equals" value="ORDER_APPROVED">
<set field="newOrderItem.statusId" value="ITEM_APPROVED"/>
<else>
<set field="newOrderItem.statusId" value="ITEM_CREATED"/>
</else>
</if-compare>
</if-empty>
<make-next-seq-id value-field="newOrderItem" seq-field-name="orderItemSeqId"/>
<create-value value-field="newOrderItem"/>

<!-- create the OrderItemShipGroupAssoc -->
<call-object-method obj-field="cart" method-name="getItemIndex" ret-field="itemIndex">
<field field="item" type="org.apache.ofbiz.order.shoppingcart.ShoppingCartItem"/>
</call-object-method>
<call-object-method obj-field="cart" method-name="getItemShipGroupIndex" ret-field="shipGroupIndex">
<field field="itemIndex" type="int"/>
</call-object-method>
<call-object-method obj-field="cart" method-name="getShipInfo" ret-field="csi">
<field field="shipGroupIndex" type="int"/>
</call-object-method>
<call-object-method obj-field="csi" method-name="getShipGroupSeqId" ret-field="shipGroupSeqId"/>

<make-value entity-name="OrderItemShipGroupAssoc" value-field="newOisga"/>
<set field="newOisga.orderId" from-field="parameters.orderId"/>
<set field="newOisga.orderItemSeqId" from-field="newOrderItem.orderItemSeqId"/>
<set field="newOisga.shipGroupSeqId" from-field="shipGroupSeqId"/>
<set field="newOisga.quantity" from-field="newOrderItem.quantity"/>
<create-value value-field="newOisga"/>

<!-- and the orderItemSeqId is assigned to the shopping cart item-->
<call-object-method obj-field="item" method-name="setOrderItemSeqId">
<field field="newOrderItem.orderItemSeqId" type="String"/>
Expand Down
Loading