Skip to content

Fixed: Canceling an item from the order view and refreshing the page caused promotional items to endlessly duplicate in the ITEM_CREATED status. #1142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arunpati merged 2 commits into from
Apr 28, 2026
Merged

Fixed: Canceling an item from the order view and refreshing the page caused promotional items to endlessly duplicate in the ITEM_CREATED status. #1142

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
541aadb
Fixed issue in Canceling an item from the order view and refreshing t…
arunpati Apr 28, 2026
6f20816
Merge branch 'trunk' of https://github.com/arunpati/arun-ofbiz-framew…
arunpati Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions applications/order/src/main/groovy/org/apache/ofbiz/order/order/OrderServicesScript.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ import org.apache.ofbiz.order.shoppingcart.ShoppingCart
import org.apache.ofbiz.order.shoppingcart.ShoppingCartItem

import java.sql.Timestamp

/**
* Service to create OrderHeader
*/
Expand Down Expand Up @@ -214,21 +213,37 @@ Map recreateOrderAdjustments() {
// a new order item is created
GenericValue newOrderItem = makeValue('OrderItem')
newOrderItem.with {
orderId = parameters.orderId
orderId = order.get("orderId")
orderItemTypeId = item.getItemType()
selectedAmount = item.getSelectedAmount()
unitPrice = item.getBasePrice()
unitListPrice = item.getListPrice()
itemDescription = item.getName(dispatcher)
itemDescription = item.getDescription()
statusId = item.getStatusId()
productId = item.getProductId()
quantity = item.getQuantity()
isModifiedPrice = 'N'
isPromo = 'Y'
statusId = newOrderItem.statusId ?: 'ITEM_CREATED'
statusId = order.statusId == 'ORDER_APPROVED' ? 'ITEM_APPROVED' : 'ITEM_CREATED'
}
newOrderItem.orderItemSeqId = delegator.getNextSeqId('OrderItem')
newOrderItem.create()

// create the OrderItemShipGroupAssoc
int itemIndex = cart.getItemIndex(item)
int shipGroupIndex = cart.getItemShipGroupIndex(itemIndex)
def csi = cart.getShipInfo(shipGroupIndex)
String shipGroupSeqId = csi.getShipGroupSeqId()

GenericValue newOisga = makeValue('OrderItemShipGroupAssoc')
newOisga.with {
orderId = order.orderId
orderItemSeqId = newOrderItem.orderItemSeqId
shipGroupSeqId = shipGroupSeqId
quantity = newOrderItem.quantity
}
newOisga.create()

// And the orderItemSeqId is assigned to the shopping cart item
item.setOrderItemSeqId(newOrderItem.orderItemSeqId)
}
Expand Down
Loading