Fixed: Order view page CSS leak from embedded email communication content#1213
Open
toaditi wants to merge 1 commit into
Open
Fixed: Order view page CSS leak from embedded email communication content#1213toaditi wants to merge 1 commit into
toaditi wants to merge 1 commit into
Conversation
…tent When a communication event exists on an order, OrderConversations dumps the stored email HTML (a full <!DOCTYPE html> document with its own <style> block) directly into the order view page. That global CSS reset cascades to the parent page and breaks the order layout — tables lose padding, the body background changes, screenlets re-style, etc. Render the email body inside an iframe so its styles are isolated. Decode the HTML-entity-encoded content client-side via a textarea before assigning to srcdoc, since the content is stored encoded in the DB. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a
CommunicationEventexists on an order, theOrderConversationsscreen dumps the stored email HTML (a full<!DOCTYPE html>document, with its own<style>block containing a global CSS reset) directly inline into the order view page. Browsers parse that<style>at document scope — not div scope — so the email's reset cascades into the parent page and breaks the order layout: tables lose padding, the body background changes,.screenletstyling is overridden, etc.Fix
Render the email body inside an
<iframe>so its CSS lives in its own document context and cannot leak. The stored content is HTML-entity-encoded, so it's decoded client-side via a<textarea>before being assigned tosrcdoc.One file changed:
applications/party/template/party/DisplayCommunicationContent.ftl.Test plan
onloadhandler).