Improved stale JobSandbox recovery handling in multi-node environment [OFBIZ-13383]#1216
Open
Ankit-Joshi11 wants to merge 1 commit into
Open
Improved stale JobSandbox recovery handling in multi-node environment [OFBIZ-13383]#1216Ankit-Joshi11 wants to merge 1 commit into
Ankit-Joshi11 wants to merge 1 commit into
Conversation
…s OFBIZ-13383 Added heartbeat based jobs tracking and recovering stale jobs that are still owned by the terminated or replaced nodes. Utilized atomic updates for the jobs heartbeat updates and recovering logic to avoid race conditions and state overriden between multiple nodes
nmalin
reviewed
May 15, 2026
| EntityCondition.makeCondition( | ||
| EntityCondition.makeCondition("leaseUpdatedStamp", EntityOperator.LESS_THAN, expiryThreshold), | ||
| EntityOperator.OR, | ||
| EntityCondition.makeCondition("leaseUpdatedStamp", EntityOperator.EQUALS, null))); |
Contributor
There was a problem hiding this comment.
Hello @Ankit-Joshi11
On environment with multiple pool, it would be useful to indicate to the JobManager to update only it dedicated pool ?
So add the condition
EntityCondition.makeCondition("poolId", EntityOperator.IN, getRunPools())
Or we just ignore the collision risk ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved: Heartbeat based jobs tracking and recovering stale jobs that are still owned by the terminated or replaced nodes. Utilized atomic updates for the jobs heartbeat updates and recovering logic to avoid race conditions and state overriden between multiple nodes