Replace generic updateOrRemove service with ProductFeatureDataResource-specific service#1227
Merged
dixitdeepak merged 1 commit intoMay 19, 2026
Conversation
…e-specific service Replaced the ambiguous updateOrRemove service with a dedicated createOrRemoveProductFeatureDataResource service for managing CMS product feature data resource links. - Added explicit productFeatureId and dataResourceId service parameters - Removed generic entityName, pkFieldCount, fieldName, and fieldValue handling - Simplified ProductFeatureDataResource create/remove logic - Updated CMSContentEdit.ftl to submit defined service parameters - Updated updateFeatures controller event to invoke the new service
dixitdeepak
added a commit
that referenced
this pull request
May 19, 2026
…e-specific service (#1227) Replaced the ambiguous updateOrRemove service with a dedicated createOrRemoveProductFeatureDataResource service for managing CMS product feature data resource links. - Added explicit productFeatureId and dataResourceId service parameters - Removed generic entityName, pkFieldCount, fieldName, and fieldValue handling - Simplified ProductFeatureDataResource create/remove logic - Updated CMSContentEdit.ftl to submit defined service parameters - Updated updateFeatures controller event to invoke the new service
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced the ambiguous updateOrRemove service with a dedicated createOrRemoveProductFeatureDataResource service for managing CMS product feature data resource links.