Skip to content

Fix JdbcSQLDataException during startup caused by null table parameter in getPrimaryKeys #1228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ashishvijaywargiya wants to merge 6 commits into from
+2 −10
Closed

Fix JdbcSQLDataException during startup caused by null table parameter in getPrimaryKeys #1228

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
543e3da
Adding the latest stable version of H2 database. The ./gradlew cleanA…
ashishvijaywargiya May 17, 2026
6dd1d6a
OFBIZ-13413 - Here is the fix to remove the null parameter attempt en…
ashishvijaywargiya May 19, 2026
6674c13
Merge branch 'apache:trunk' into trunk
ashishvijaywargiya May 19, 2026
c0e3459
Merge remote-tracking branch 'origin/trunk' into trunk
ashishvijaywargiya May 19, 2026
30b479c
Revert "OFBIZ-13413 - Here is the fix to remove the null parameter at…
ashishvijaywargiya May 19, 2026
c9ff8a3
OFBIZ-13413 - Here is the fix to remove the null parameter attempt en…
ashishvijaywargiya May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions framework/entity/src/main/java/org/apache/ofbiz/entity/jdbc/DatabaseUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1228,20 +1228,12 @@ private Map<String, Map<String, ColumnCheckInfo>> getColumnInfo(Set<String> tabl

// first try getting all at once for databases that support that and can generally perform WAY better, if that fails get one at
// a time so it will at least work
try (ResultSet rsPks = dbData.getPrimaryKeys(null, lookupSchemaName, null)) {
try (ResultSet rsPks = dbData.getPrimaryKeys(null, lookupSchemaName, "%")) {
pkCount += checkPrimaryKeyInfo(rsPks, lookupSchemaName, needsUpperCase, colInfo, messages);
} catch (Exception e1) {
Debug.logInfo("Error getting primary key info from database with null tableName, will try other means: " + e1.toString(),
Debug.logInfo("Error getting primary key info from database with % tableName, will try other means: " + e1.toString(),
MODULE);
}
if (pkCount == 0) {
try (ResultSet rsPks = dbData.getPrimaryKeys(null, lookupSchemaName, "%")) {
pkCount += checkPrimaryKeyInfo(rsPks, lookupSchemaName, needsUpperCase, colInfo, messages);
} catch (Exception e1) {
Debug.logInfo("Error getting primary key info from database with % tableName, will try other means: " + e1.toString(),
MODULE);
}
}
if (pkCount == 0) {
Debug.logInfo("Searching in " + tableNames.size() + " tables for primary key fields ...", MODULE);
for (String curTable : tableNames) {
Expand Down
Loading