Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
import org.apache.ofbiz.entity.condition.EntityOperator;
import org.apache.ofbiz.entity.util.EntityQuery;
import org.apache.ofbiz.entity.util.EntityUtil;
import org.apache.ofbiz.entityext.permission.EntityPermissionChecker;
import org.apache.ofbiz.content.permission.EntityPermissionChecker;
import org.apache.ofbiz.minilang.MiniLangException;
import org.apache.ofbiz.security.Security;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
import org.apache.ofbiz.entity.GenericEntityException;
import org.apache.ofbiz.entity.GenericValue;
import org.apache.ofbiz.entity.util.EntityQuery;
import org.apache.ofbiz.entityext.permission.EntityPermissionChecker;
import org.apache.ofbiz.content.permission.EntityPermissionChecker;
import org.apache.ofbiz.security.Security;
import org.apache.ofbiz.service.DispatchContext;
import org.apache.ofbiz.service.GenericServiceException;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*******************************************************************************/
package org.apache.ofbiz.entityext.permission;
package org.apache.ofbiz.content.permission;

import java.util.ArrayList;
import java.util.Arrays;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
import org.apache.ofbiz.content.content.PermissionRecorder;
import org.apache.ofbiz.entity.Delegator;
import org.apache.ofbiz.entity.GenericValue;
import org.apache.ofbiz.entityext.permission.EntityPermissionChecker;
import org.apache.ofbiz.content.permission.EntityPermissionChecker;
import org.apache.ofbiz.security.Security;
import org.apache.ofbiz.service.ModelService;
import org.apache.ofbiz.webapp.ftl.LoopWriter;
Expand Down
23 changes: 0 additions & 23 deletions framework/widget/dtd/widget-common.xsd
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ under the License.
<xs:element ref="not" />
<xs:element ref="if-service-permission" />
<xs:element ref="if-has-permission" />
<xs:element ref="if-entity-permission" />
<xs:element ref="if-validate-method" />
<xs:element ref="if-compare" />
<xs:element ref="if-compare-field" />
Expand Down Expand Up @@ -87,28 +86,6 @@ under the License.
<xs:attribute type="xs:string" name="action" />
</xs:complexType>
</xs:element>
<xs:element name="if-entity-permission" substitutionGroup="AllConditionals">
<xs:complexType>
<xs:choice minOccurs="0">
<xs:element minOccurs="0" maxOccurs="1" ref="permission-condition-getter" />
<xs:element minOccurs="0" maxOccurs="1" ref="related-role-getter" />
<xs:element minOccurs="0" maxOccurs="1" ref="auxiliary-value-getter" />
</xs:choice>
<xs:attribute type="xs:string" name="entity-name" use="required" />
<xs:attribute type="xs:string" name="entity-id" use="required">
<xs:annotation>
<xs:documentation>Can have multiple pipe separated values, but don't use spaces.</xs:documentation>
</xs:annotation>
</xs:attribute>
<xs:attribute type="xs:string" name="target-operation" use="required">
<xs:annotation>
<xs:documentation>Can have multiple pipe separated values, but don't use spaces.</xs:documentation>
</xs:annotation>
</xs:attribute>
<xs:attribute name="display-fail-cond" type="xs:boolean"
default="false"/>
</xs:complexType>
</xs:element>
<xs:element name="permission-condition-getter">
<xs:complexType>
<xs:attribute type="xs:string" name="entity-name" />
Expand Down
1 change: 0 additions & 1 deletion framework/widget/dtd/widget-screen.xsd
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ under the License.
<xs:element ref="not" />
<xs:element ref="if-service-permission" />
<xs:element ref="if-has-permission" />
<xs:element ref="if-entity-permission" />
<xs:element ref="if-validate-method" />
<xs:element ref="if-compare" />
<xs:element ref="if-compare-field" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
import org.apache.ofbiz.base.util.collections.FlexibleMapAccessor;
import org.apache.ofbiz.base.util.string.FlexibleStringExpander;
import org.apache.ofbiz.entity.GenericValue;
import org.apache.ofbiz.entityext.permission.EntityPermissionChecker;
import org.apache.ofbiz.minilang.operation.BaseCompare;
import org.apache.ofbiz.security.Security;
import org.apache.ofbiz.service.DispatchContext;
Expand Down Expand Up @@ -209,8 +208,6 @@ protected ModelCondition newInstance(ModelConditionFactory factory, ModelWidget
return new IfRegexp(factory, modelWidget, conditionElement);
} else if ("if-empty".equals(nodeName)) {
return new IfEmpty(factory, modelWidget, conditionElement);
} else if ("if-entity-permission".equals(nodeName)) {
return new IfEntityPermission(factory, modelWidget, conditionElement);
} else {
throw new IllegalArgumentException("Condition element not supported with name: " + conditionElement.getNodeName());
}
Expand Down Expand Up @@ -406,33 +403,6 @@ public FlexibleMapAccessor<Object> getFieldAcsr() {

}

/**
* Models the &lt;if-entity-permission&gt; element.
* @see <code>widget-common.xsd</code>
*/
public static final class IfEntityPermission extends AbstractModelCondition {
private final EntityPermissionChecker permissionChecker;

private IfEntityPermission(ModelConditionFactory factory, ModelWidget modelWidget, Element condElement) {
super(factory, modelWidget, condElement);
this.permissionChecker = new EntityPermissionChecker(condElement);
}

@Override
public void accept(ModelConditionVisitor visitor) throws Exception {
visitor.visit(this);
}

@Override
public boolean eval(Map<String, Object> context) {
return permissionChecker.runPermissionCheck(context);
}

public EntityPermissionChecker getPermissionChecker() {
return permissionChecker;
}
}

/**
* Models the &lt;if-has-permission&gt; element.
* @see <code>widget-common.xsd</code>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
import org.apache.ofbiz.widget.model.AbstractModelCondition.IfCompare;
import org.apache.ofbiz.widget.model.AbstractModelCondition.IfCompareField;
import org.apache.ofbiz.widget.model.AbstractModelCondition.IfEmpty;
import org.apache.ofbiz.widget.model.AbstractModelCondition.IfEntityPermission;
import org.apache.ofbiz.widget.model.AbstractModelCondition.IfHasPermission;
import org.apache.ofbiz.widget.model.AbstractModelCondition.IfRegexp;
import org.apache.ofbiz.widget.model.AbstractModelCondition.IfServicePermission;
Expand All @@ -45,8 +44,6 @@ public interface ModelConditionVisitor {

void visit(IfEmpty ifEmpty) throws Exception;

void visit(IfEntityPermission ifEntityPermission) throws Exception;

void visit(IfHasPermission ifHasPermission) throws Exception;

void visit(IfRegexp ifRegexp) throws Exception;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
import org.apache.ofbiz.base.util.collections.FlexibleMapAccessor;
import org.apache.ofbiz.base.util.string.FlexibleStringExpander;
import org.apache.ofbiz.entity.GenericValue;
import org.apache.ofbiz.entityext.permission.EntityPermissionChecker;
import org.apache.ofbiz.minilang.operation.BaseCompare;
import org.apache.ofbiz.security.Security;
import org.apache.ofbiz.service.DispatchContext;
Expand Down Expand Up @@ -181,8 +180,6 @@ public Condition newInstance(ModelWidget modelWidget, Element conditionElement)
return new IfRegexp(this, modelWidget, conditionElement);
} else if ("if-empty".equals(nodeName)) {
return new IfEmpty(this, modelWidget, conditionElement);
} else if ("if-entity-permission".equals(nodeName)) {
return new IfEntityPermission(this, modelWidget, conditionElement);
} else {
throw new IllegalArgumentException("Condition element not supported with name: " + nodeName);
}
Expand Down Expand Up @@ -318,24 +315,6 @@ public boolean eval(Map<String, Object> context) {
}
}

/**
* Models the &lt;if-entity-permission&gt; element.
* @see <code>widget-common.xsd</code>
*/
public static final class IfEntityPermission extends ModelWidgetCondition implements Condition {
private final EntityPermissionChecker permissionChecker;

private IfEntityPermission(ConditionFactory factory, ModelWidget modelWidget, Element condElement) {
super(factory, modelWidget, condElement);
this.permissionChecker = new EntityPermissionChecker(condElement);
}

@Override
public boolean eval(Map<String, Object> context) {
return permissionChecker.runPermissionCheck(context);
}
}

/**
* Models the &lt;if-has-permission&gt; element.
* @see <code>widget-common.xsd</code>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
import org.apache.ofbiz.widget.model.AbstractModelCondition.IfCompare;
import org.apache.ofbiz.widget.model.AbstractModelCondition.IfCompareField;
import org.apache.ofbiz.widget.model.AbstractModelCondition.IfEmpty;
import org.apache.ofbiz.widget.model.AbstractModelCondition.IfEntityPermission;
import org.apache.ofbiz.widget.model.AbstractModelCondition.IfHasPermission;
import org.apache.ofbiz.widget.model.AbstractModelCondition.IfRegexp;
import org.apache.ofbiz.widget.model.AbstractModelCondition.IfServicePermission;
Expand Down Expand Up @@ -91,13 +90,6 @@ public void visit(IfEmptySection ifEmptySection) throws Exception {
writer.append("/>");
}

@Override
public void visit(IfEntityPermission ifEntityPermission) throws Exception {
writer.append("<if-entity-permission");
// TODO: Create EntityPermissionChecker visitor
writer.append("/>");
}

@Override
public void visit(IfHasPermission ifHasPermission) throws Exception {
writer.append("<if-has-permission");
Expand Down
Loading