Skip to content

Fixed: Add license header to ServiceContextCleanupFilter.java#208

Closed
golja wants to merge 1 commit into
apache:trunkfrom
golja:add-licence-header
Closed

Fixed: Add license header to ServiceContextCleanupFilter.java#208
golja wants to merge 1 commit into
apache:trunkfrom
golja:add-licence-header

Conversation

@golja

@golja golja commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

In the output of the latest run of the buildbot builder ofbizTrunkFrameworkRat, it is reported that the file

rest-api/src/main/java/org/apache/ofbiz/ws/rs/filters/ServiceContextCleanupFilter.java

has an unapproved license. The reason is that the license header is missing.

@sonarqubecloud

Copy link
Copy Markdown

@JacquesLeRoux

Copy link
Copy Markdown
Contributor

Thanks Anahita,

There is also UtilCacheTest.groovy, UtilCacheTestTools.groovy and ServiceContextCleanupFilter.java. I have fixed them directly (easier than adding to your PR) before pushing this PR.

There is also pdftest2.pdf. I have asked Infra about that.

@JacquesLeRoux

JacquesLeRoux commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

Oops, actually I did also ServiceContextCleanupFilter.java. I close here, sorry and thanks for he effort.

@golja

golja commented Apr 20, 2026

Copy link
Copy Markdown
Contributor Author

Thanks Anahita,

There is also UtilCacheTest.groovy, UtilCacheTestTools.groovy and ServiceContextCleanupFilter.java. I have fixed them directly (easier than adding to your PR) before pushing this PR.

There is also pdftest2.pdf. I have asked Infra about that.

Hi @JacquesLeRoux,
changes to ServiceContextCleanupFilter.java are included in this PR. The other two files you mentioned (UtilCacheTest.groovy, UtilCacheTestTools.groovy) are in the ofbiz-framework repository, not in the ofbiz-plugins repository. That’s why this PR only includes changes to the ServiceContextCleanupFilter.

For your information, alongside this PR I’ve also submitted another PR to ofbiz-framework with changes to the other two files.

Anahita

@JacquesLeRoux

Copy link
Copy Markdown
Contributor

Hi @golja ,

Yes I know, I added them all Saturday around 9AM, that's why I closed this PR. I don't remember for the framework PR.

@JacquesLeRoux

Copy link
Copy Markdown
Contributor

Ah, Jacopo closed it: apache/ofbiz-framework#1122

@JacquesLeRoux

Copy link
Copy Markdown
Contributor

You were right for me mixing framework and plugins, sorry.

@golja golja deleted the add-licence-header branch May 20, 2026 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants