Skip to content

Commit 79d76b1

Browse files
committed
Fix review comments
1 parent c2fcb1f commit 79d76b1

5 files changed

Lines changed: 308 additions & 264 deletions

File tree

hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineManager.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
import org.apache.hadoop.hdds.protocol.DatanodeDetails;
2828
import org.apache.hadoop.hdds.scm.container.ContainerID;
2929
import org.apache.hadoop.hdds.scm.container.ContainerReplica;
30-
import org.apache.hadoop.hdds.scm.node.DatanodeInfo;
3130
import org.apache.hadoop.hdds.utils.db.CodecException;
3231
import org.apache.hadoop.hdds.utils.db.RocksDatabaseException;
3332
import org.apache.hadoop.hdds.utils.db.Table;
@@ -228,11 +227,4 @@ void reinitialize(Table<PipelineID, Pipeline> pipelineStore)
228227
* Get the pipeline metrics.
229228
*/
230229
SCMPipelineMetrics getMetrics();
231-
232-
/**
233-
* Get DatanodeInfo for a specific DataNode which includes per-volume storage reports.
234-
* @param datanodeDetails The datanode to get info for
235-
* @return DatanodeInfo containing detailed node information including per-disk stats, or null if not available
236-
*/
237-
DatanodeInfo getDatanodeInfo(DatanodeDetails datanodeDetails);
238230
}

hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineManagerImpl.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@
5353
import org.apache.hadoop.hdds.scm.ha.SCMContext;
5454
import org.apache.hadoop.hdds.scm.ha.SCMHAManager;
5555
import org.apache.hadoop.hdds.scm.ha.SCMServiceManager;
56-
import org.apache.hadoop.hdds.scm.node.DatanodeInfo;
5756
import org.apache.hadoop.hdds.scm.node.NodeManager;
5857
import org.apache.hadoop.hdds.scm.server.upgrade.FinalizationManager;
5958
import org.apache.hadoop.hdds.server.events.EventPublisher;
@@ -644,11 +643,6 @@ public boolean hasEnoughSpace(Pipeline pipeline, long containerSize) {
644643
return true;
645644
}
646645

647-
@Override
648-
public DatanodeInfo getDatanodeInfo(DatanodeDetails datanodeDetails) {
649-
return nodeManager.getDatanodeInfo(datanodeDetails);
650-
}
651-
652646
/**
653647
* Schedules a fixed interval job to create pipelines.
654648
*/

0 commit comments

Comments
 (0)