Skip to content

Commit 892ceb5

Browse files
authored
HDDS-14632. TestDefault...ChoosingPolicy failing due to cluster ID mismatch (#9761)
1 parent 357aad7 commit 892ceb5

3 files changed

Lines changed: 8 additions & 4 deletions

File tree

hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/diskbalancer/TestDefaultContainerChoosingPolicy.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717

1818
package org.apache.hadoop.ozone.container.diskbalancer;
1919

20+
import static org.apache.hadoop.hdds.scm.ScmConfigKeys.HDDS_DATANODE_DIR_KEY;
2021
import static org.apache.hadoop.ozone.container.common.impl.ContainerImplTestUtils.newContainerSet;
2122
import static org.junit.jupiter.api.Assertions.assertEquals;
2223
import static org.junit.jupiter.api.Assertions.assertNotNull;
@@ -106,6 +107,8 @@ private void setupVolumesAndContainer() throws IOException {
106107
destVolume1 = createVolume("dest-volume1", 0.10);
107108
destVolume2 = createVolume("dest-volume2", 0.50);
108109

110+
CONF.set(HDDS_DATANODE_DIR_KEY, baseDir.resolve("defaultVolume").toString());
111+
109112
// Create and spy on the volume set
110113
String datanodeUuid = UUID.randomUUID().toString();
111114
volumeSet = spy(new MutableVolumeSet(datanodeUuid, CONF, null,

hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/diskbalancer/TestDefaultVolumeChoosingPolicy.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717

1818
package org.apache.hadoop.ozone.container.diskbalancer;
1919

20+
import static org.apache.hadoop.hdds.scm.ScmConfigKeys.HDDS_DATANODE_DIR_KEY;
2021
import static org.apache.hadoop.ozone.container.diskbalancer.DiskBalancerVolumeCalculation.getVolumeUsages;
2122
import static org.junit.jupiter.api.Assertions.assertEquals;
2223
import static org.junit.jupiter.api.Assertions.assertNotNull;
@@ -233,11 +234,9 @@ private List<HddsVolume> createVolumes(List<VolumeTestConfig> configs)
233234
* @param volumes List of volumes to add to volume set
234235
*/
235236
private void setupVolumeSet(List<HddsVolume> volumes) throws IOException {
236-
// Create volume set without any default volumes from configuration
237237
// Use a clean configuration to avoid loading default volumes
238238
OzoneConfiguration testConf = new OzoneConfiguration();
239-
// Explicitly set HDDS_DATANODE_DIR_KEY to empty to prevent default volumes
240-
testConf.set("hdds.datanode.dir.key", "");
239+
testConf.set(HDDS_DATANODE_DIR_KEY, baseDir.resolve("defaultVolume").toString());
241240
volumeSet = new MutableVolumeSet(datanodeUuid, testConf, null,
242241
StorageVolume.VolumeType.DATA_VOLUME, null);
243242

hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/upgrade/TestDatanodeUpgradeToSchemaV3.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,10 @@ private void initTests(Boolean enable) throws Exception {
9494
private void setup() throws Exception {
9595
address = SCMTestUtils.getReuseableAddress();
9696
conf.setSocketAddr(ScmConfigKeys.OZONE_SCM_NAMES, address);
97+
conf.set(ScmConfigKeys.HDDS_DATANODE_DIR_KEY,
98+
tempFolder.resolve("data").toString());
9799
conf.set(HddsConfigKeys.OZONE_METADATA_DIRS,
98-
tempFolder.toString());
100+
tempFolder.resolve("meta").toString());
99101
}
100102

101103
@AfterEach

0 commit comments

Comments
 (0)