HDDS-13117. Add Conditional Writes, Reads, Copies, Deletes and CompleteMultipartUpload Design#10010
Conversation
There was a problem hiding this comment.
Pull request overview
Adds/expands the design document for AWS S3-style conditional requests in Ozone’s S3 Gateway/OM paths, covering intended semantics and an incremental delivery plan aligned to HDDS-13117.
Changes:
- Expands the specification sections for conditional writes/reads/copies and adds conditional deletes coverage.
- Adds proposed gateway/OM implementation flows, including atomicity and error-mapping discussions.
- Adds references and clarifies current state + phased delivery plan.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
peterxcli
requested review from
errose28,
ivandika3,
jojochuang,
kerneltime and
sodonnel
|
@ivandika3 @jojochuang Please take a look when you have time, thanks! |
jojochuang
left a comment
jojochuang
left a comment
There was a problem hiding this comment.
AWS S3 supports conditional requests for multipart upload. Specifically, If-Match, If-None-Match for CompleteMultipartUpload.
Is that being considered or is it left out internationally? Just like to know what else remains unsupported once this design and implementation is complete.
|
peterxcli
changed the title
peterxcli
changed the title
thanks, I updated the design and raised a jira for it: https://issues.apache.org/jira/browse/HDDS-15067 |
There was a problem hiding this comment.
Thanks @peterxcli , overall LGTM. Left some comments.
I think you can start on the implementation. I believe that as long as we can check the implementation against https://github.com/peterxcli/ozone-s3-compatibility, it should be OK.
Signed-off-by: peterxcli <peterxcli@gmail.com>
|
Thanks @ivandika3, @jojochuang for the review! |
What changes were proposed in this pull request?
Add conditional writes, reads, copies, and deletes design
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13117
How was this patch tested?