HDDS-13920. Conditional Reads (GetObject, HeadObject)#10031
Merged
Conversation
Add tests for If-Match, If-None-Match, If-Modified-Since, and If-Unmodified-Since headers in both GET and HEAD requests. Enhance response handling for conditional requests in ObjectEndpoint.
ivandika3
reviewed
Apr 9, 2026
ivandika3
left a comment
ivandika3
left a comment
Contributor
There was a problem hiding this comment.
@peterxcli Thanks for the patch, left some comments.
| /** | ||
| * Shared parsing and evaluation for S3 conditional request headers. | ||
| */ | ||
| final class S3ConditionalRequest { |
Contributor
There was a problem hiding this comment.
Is the conditional request logic can be implemented as ObjectOperationHandler (the chain of responsibility pattern)? I'm OK to leave it be if it's too tedious.
ivandika3
reviewed
Apr 10, 2026
ivandika3
left a comment
ivandika3
left a comment
Contributor
There was a problem hiding this comment.
Thanks @peterxcli , LGTM +1.
This can be merged after merge conflicts are resolved.
ivandika3
approved these changes
Apr 10, 2026
Member
Author
|
Thanks @ivandika3 for the review! |
Member
Author
|
we could also test our conditional requests perf. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Implement S3 Conditional Reads for Ozone and introduce
S3ConditionalRequestclass to centralized conditional request logic.Only s3gateway involve for Conditional Reads.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13920
How was this patch tested?
Unit test, S3 SDK test