HDDS-15007. SCM Web UI search box should filter the entire datanodes set, not just the displayed rows #10076
Open
navinko wants to merge 2 commits intoapache:masterfrom
Open
HDDS-15007. SCM Web UI search box should filter the entire datanodes set, not just the displayed rows #10076navinko wants to merge 2 commits intoapache:masterfrom
navinko wants to merge 2 commits intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Implemented globalSearch for Node Status Search bar.
'HDDS-15007. SCM Web UI search box should filter the entire datanodes set, not just the displayed rows '
In the existing design, the search box on the SCM Web UI "Node Status" table had a page-level filter where we could only search across the currently visible rows governed by 'Show' dropdown (e.g., 10 ,20, 50 , All nodes at a time). Finding a specific datanode in a large cluster requires :
1: Either change the 'Show' dropdown to have more records in the table manually + search -> If target match found Ok else clicking through multiple pages in (previous - next ) fashion until the target node appeared on the active page.
2: Keep searching on the table with default size 10
Proposed Changes:
This PR introduces a global search mechanism to the SCM Web UI. The search input now filters against the entire master dataset of datanodes before the pagination slicing occurs, allowing users to instantly find nodes regardless of which page they originally resided on. Also it shows the pagination .
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15007
How was this patch tested?
-> page-1
-> page-2
-> Search "ozone-ha-datanode-7.ozone-ha_default" UUID on serach bar at Page-1
If we could have search on page-2, we have the target match , and since have one more records on 3rd page next navigation is enable.
Scaled the cluster to 21 datanodes using docker-compose up --scale datanode=21 to force multiple pages of records.
Navigated to Page 1 and searched for a datanode known to be located on Page 2. Verified that the node immediately appeared in the table. Verified that the pagination text dynamically updated to reflect the search results (e.g., "Showing 1 to 1 of the total 1 entries.") and that the Next/Previous buttons disabled appropriately to prevent navigating to empty pages.
Cleared the search box and verified that the table restored the full cluster view and correct pagination.
-> page-1
-> page-2 (taken ozone-ha-datanode-19.ozone-ha_default for global serach)
-> page-3
-> global serach found! (ozone-ha-datanode-19.ozone-ha_default -found)
-> prev, next navigation disabled