HDDS-15034. Query SCM status for ozone admin upgrade status command#10084
Open
dombizita wants to merge 10 commits intoapache:HDDS-14496-zdufrom
Open
HDDS-15034. Query SCM status for ozone admin upgrade status command#10084dombizita wants to merge 10 commits intoapache:HDDS-14496-zdufrom
dombizita wants to merge 10 commits intoapache:HDDS-14496-zdufrom
Conversation
sodonnel
reviewed
Apr 17, 2026
github-actions
Bot
added
the
zdu
sodonnel
reviewed
Apr 17, 2026
Contributor
Author
|
Thank you for the review @sodonnel, addressed your comments in the latest commit. |
sodonnel
reviewed
Apr 20, 2026
sodonnel
reviewed
Apr 20, 2026
Contributor
Author
|
Thanks @sodonnel, based on you comments and offline discussion I agree that it's safer and easier to just get the count each time while iterating through the nodes and not store it as a counter, which could go out of sync because of corner cases |
sodonnel
reviewed
Apr 21, 2026
sodonnel
approved these changes
Apr 21, 2026
Contributor
sodonnel
left a comment
sodonnel
left a comment
There was a problem hiding this comment.
This version looks good if we get green CI.
errose28
requested changes
Apr 21, 2026
Contributor
errose28
left a comment
errose28
left a comment
There was a problem hiding this comment.
Thanks for working on this @dombizita. I don't think we are quite ready to merge yet.
errose28
approved these changes
Apr 24, 2026
|
|
||
| for (DatanodeDetails dn : getAllNodes()) { | ||
| try { | ||
| // Only count HEALTHY nodes. STALE/DEAD nodes are intentionally excluded |
Contributor
There was a problem hiding this comment.
We can put this in the javadoc for the method to indicate the nodes it is operating on. Also we should document the reasoning for allowing all operational states.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
After #10011 is merged the hardcoded placeholder responses can be removed and connect it to SCM for real values. Based on @errose28's suggestion I used HDDSLayoutVersionManager to check the finalization status of SCM and added a new counter to SCMNodeManager to keep track of the number of DNs finalized and used that for the
ozone admin upgrade statusoutput.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15034
How was this patch tested?
Added tests, green CI on my fork: https://github.com/dombizita/ozone/actions/runs/24517013218