HDDS-15094. Add protocol and cipher config to gRPC TLS config#10114
Merged
Conversation
adoroszlai
reviewed
Apr 28, 2026
adoroszlai
left a comment
adoroszlai
left a comment
Contributor
There was a problem hiding this comment.
Thanks @fapifta for the patch.
Comment on lines
+148
to
+153
| if (secConf.getGrpcTlsProtocols() != null) { | ||
| sslContextBuilder.protocols(secConf.getGrpcTlsProtocols()); | ||
| } | ||
| if (secConf.getGrpcTlsCiphers() != null) { | ||
| sslContextBuilder.ciphers(secConf.getGrpcTlsCiphers()); | ||
| } |
Contributor
There was a problem hiding this comment.
SslContextBuilder handles null (meaning "uses default cipher suites/protocols"), so we can omit null checks in all users of these new configs.
Generated-by: Claude - Opus 4.6
dombizita
approved these changes
Apr 28, 2026
adoroszlai
approved these changes
Apr 28, 2026
Contributor
|
Thanks @fapifta for the patch, @dombizita for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add protocol and cipher config to gRPC TLS config
Please describe your PR in detail:
This change enables Ozone administrators to restrict TLS protocol versions and cipher suites on all gRPC server endpoints (OzoneManager, XceiverServer, ReplicationServer, InterSCMGrpcProtocolService) via two new configuration keys: hdds.grpc.tls.protocols (e.g. "TLSv1.3") and hdds.grpc.tls.ciphers
(e.g. "TLS_AES_256_GCM_SHA384,TLS_AES_128_GCM_SHA256").
When unset, provider defaults are preserved for full backward compatibility. The configuration is parsed in SecurityConfig and applied server-side only — clients are intentionally unrestricted since the server controls TLS handshake negotiation.
The PR is generated by: Claude - Opus 4.6
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15094
How was this patch tested?
New tests verify both config parsing (7 cases in TestSecurityConfigTlsSettings) and actual TLS handshake enforcement including protocol version rejection and cipher mismatch failure (5 cases in TestGrpcTlsConfig).