HDDS-15080. DirectoryDeletingService is using single thread#10125
Merged
ashishkumar50 merged 9 commits intoapache:masterfrom Apr 29, 2026
Merged
HDDS-15080. DirectoryDeletingService is using single thread#10125ashishkumar50 merged 9 commits intoapache:masterfrom
ashishkumar50 merged 9 commits intoapache:masterfrom
Conversation
ptlrs
approved these changes
Apr 24, 2026
Contributor
ptlrs
left a comment
There was a problem hiding this comment.
Thanks for the patch @aryangupta1998. LGTM
adoroszlai
reviewed
Apr 25, 2026
Contributor
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @aryangupta1998 for the patch.
Contributor
ashishkumar50
left a comment
There was a problem hiding this comment.
@aryangupta1998 Thanks for working on this, can you also have a test to see if multiple threads are executing in parallel.
Contributor
|
@aryangupta1998 Can you add a test if multiple threads are executing in parallel. |
added 3 commits
April 29, 2026 10:12
ptlrs
approved these changes
Apr 29, 2026
Contributor
ptlrs
left a comment
There was a problem hiding this comment.
Thanks for the updates @aryangupta1998. LGTM
ashishkumar50
approved these changes
Apr 29, 2026
Contributor
ashishkumar50
left a comment
There was a problem hiding this comment.
@aryangupta1998 Thanks for updating patch, LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Switched DirectoryDeletingService to consistently use a fixed-size parallel deletion pool instead of the previous core-0 setup.
Unified pool creation so constructor/start/restart all follow the same path and behave the same after reconfiguration.
Also fixed thread-count reconfig handling so updated values are actually used by worker creation and pool recreation.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15080
How was this patch tested?
Tested Manually on a cluster.