HDDS-15112. Handle negative space usage values gracefully in CachingSpaceUsageSource#10130
Merged
aryangupta1998 merged 2 commits intoapache:masterfrom Apr 28, 2026
Conversation
…SpaceUsageSource`.
rnblough
approved these changes
Apr 28, 2026
Contributor
rnblough
left a comment
rnblough
left a comment
There was a problem hiding this comment.
This looks good. We drop the problem of clusters with pre-existing negative usedBytes running afoul of the assert condition, and keep the information via the warn logs.
…lues in `CachingSpaceUsageSource`.
aryangupta1998
approved these changes
Apr 28, 2026
Contributor
aryangupta1998
left a comment
aryangupta1998
left a comment
There was a problem hiding this comment.
Thanks for the patch @ptlrs, LGTM!
errose28
approved these changes
Apr 28, 2026
Contributor
|
Thanks @errose28, @sumitagrawl, and @rnblough for the reviews! |
ptlrs
deleted the
HDDS-15112-Allow-containers-of-all-sizes-to-be-imported
branch
Contributor
Author
|
Thanks for the reviews @rnblough @sumitagrawl @errose28 @aryangupta1998 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, container sizes <= 0 in CachingSpaceUsageSource prevent a few operations from proceeding.
We should update the validations to be handled gracefully instead of blocking operations.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15112
How was this patch tested?
CI: https://github.com/ptlrs/ozone/actions/runs/24917153879