HDDS-15155. Add ozone debug ldb drop_column_family subcommand#10167
Open
smengcl wants to merge 2 commits intoapache:masterfrom
Open
HDDS-15155. Add ozone debug ldb drop_column_family subcommand#10167smengcl wants to merge 2 commits intoapache:masterfrom
ozone debug ldb drop_column_family subcommand#10167smengcl wants to merge 2 commits intoapache:masterfrom
Conversation
Generated-by: GPT-5.5
smengcl
force-pushed
the
HDDS-15155-drop-cf
branch
from
c789942 to
a2721f7
Compare
adoroszlai
reviewed
May 1, 2026
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @smengcl for the patch.
Contributor
|
looks good |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new ozone debug ldb subcommand to drop a RocksDB column family, along with unit/integration tests and user documentation to support safe usage.
Changes:
- Add
drop-column-familysubcommand toozone debug ldbfor dropping a specified column family (with interactive confirmation by default). - Add unit tests covering success, error cases, confirmation behavior, and failure when DB is already open.
- Add an integration test validating dropping
snapshotInfoTablefrom an OM DB checkpoint, plus documentation updates.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/shell/TestOzoneDebugShell.java | Adds integration coverage for dropping snapshotInfoTable from an OM checkpoint DB. |
| hadoop-ozone/cli-debug/src/test/java/org/apache/hadoop/ozone/debug/ldb/TestDropColumnFamily.java | Adds unit tests for the new drop-column-family command (including confirmations and DB-open failure). |
| hadoop-ozone/cli-debug/src/main/java/org/apache/hadoop/ozone/debug/ldb/RDBParser.java | Registers DropColumnFamily as an ozone debug ldb subcommand. |
| hadoop-ozone/cli-debug/src/main/java/org/apache/hadoop/ozone/debug/ldb/DropColumnFamily.java | Implements the new drop-column-family command. |
| hadoop-hdds/docs/content/tools/debug/Ldb.md | Documents the new command and its confirmation behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+44
to
+46
| @CommandLine.Command( | ||
| name = "drop-column-family", | ||
| description = "Drop a column family from the DB.") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated-by: GPT-5.5
What changes were proposed in this pull request?
Add drop_column_family subcommand under
ozone debug ldb.e.g.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15155
How was this patch tested?